From: "Mark Pearson" <mpearson-lenovo@squebb•ca>
To: "Stephen Rothwell" <sfr@canb•auug.org.au>,
"Wim Van Sebroeck" <wim@iguana•be>
Cc: "Guenter Roeck" <linux@roeck-us•net>,
"Wim Van Sebroeck" <wim@linux-watchdog•org>,
"Linux Kernel Mailing List" <linux-kernel@vger•kernel.org>,
"Linux Next Mailing List" <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the watchdog tree
Date: Tue, 11 Mar 2025 08:12:41 -0400 [thread overview]
Message-ID: <3da76007-31f0-404a-a324-dd3068e339c5@app.fastmail.com> (raw)
In-Reply-To: <20250311210305.3c5a2313@canb.auug.org.au>
Thanks Stephen,
On Tue, Mar 11, 2025, at 6:03 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the watchdog tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/watchdog/lenovo_se30_wdt.c: In function 'lenovo_se30_wdt_probe':
> drivers/watchdog/lenovo_se30_wdt.c:272:31: error: implicit declaration
> of function 'devm_ioremap' [-Wimplicit-function-declaration]
> 272 | priv->shm_base_addr = devm_ioremap(dev, base_phys,
> SHM_WIN_SIZE);
> | ^~~~~~~~~~~~
> drivers/watchdog/lenovo_se30_wdt.c:272:29: error: assignment to
> 'unsigned char *' from 'int' makes pointer from integer without a cast
> [-Wint-conversion]
> 272 | priv->shm_base_addr = devm_ioremap(dev, base_phys,
> SHM_WIN_SIZE);
> | ^
>
> Caused by commit
>
> c284153a2c55 ("watchdog: lenovo_se30_wdt: Watchdog driver for Lenovo
> SE30 platform")
>
> Somewhere alogn the way a change to some include file means that
> linux/io.h is no longer implicitly included. I have added the following
> patch for today.
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Tue, 11 Mar 2025 20:50:05 +1100
> Subject: [PATCH] watchdog: lenovo_se30_wdt: include io.h for devm_ioremap()
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> drivers/watchdog/lenovo_se30_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/lenovo_se30_wdt.c
> b/drivers/watchdog/lenovo_se30_wdt.c
> index f25429da0cec..024b842499b3 100644
> --- a/drivers/watchdog/lenovo_se30_wdt.c
> +++ b/drivers/watchdog/lenovo_se30_wdt.c
> @@ -5,6 +5,7 @@
>
> #define dev_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> +#include <linux/io.h>
> #include <linux/dmi.h>
> #include <linux/delay.h>
> #include <linux/iommu.h>
> --
> 2.45.2
>
> --
Appreciate you getting this done so fast - it was on my todo list for today.
Apologies for the build break.
Change looks good to me.
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb•ca>
Mark
next prev parent reply other threads:[~2025-03-11 12:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:03 linux-next: build failure after merge of the watchdog tree Stephen Rothwell
2025-03-11 12:12 ` Mark Pearson [this message]
2025-03-11 14:54 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2024-09-11 4:55 Stephen Rothwell
2024-09-11 10:42 ` Prabhakar Mahadev Lad
2024-09-11 10:48 ` Stephen Rothwell
2024-09-13 5:44 ` Stephen Rothwell
2024-09-13 8:31 ` Wim Van Sebroeck
2024-09-13 8:54 ` Prabhakar Mahadev Lad
2021-06-21 5:38 Stephen Rothwell
2021-06-21 8:08 ` Wim Van Sebroeck
2021-06-22 15:27 ` Vaittinen, Matti
2020-12-14 5:23 Stephen Rothwell
2020-12-14 6:09 ` Guenter Roeck
2020-12-16 2:56 ` Stephen Rothwell
2020-12-16 4:11 ` Guenter Roeck
2020-12-16 15:27 ` Wim Van Sebroeck
2020-12-17 7:04 ` Wim Van Sebroeck
2014-09-26 5:40 Stephen Rothwell
2014-09-26 5:51 ` Guenter Roeck
2014-09-26 6:29 ` Stephen Rothwell
2014-09-26 6:49 ` Guenter Roeck
2014-09-26 5:56 ` Pramod Gurav
2014-09-26 6:12 ` Guenter Roeck
2014-09-26 6:34 ` Stephen Rothwell
2014-09-26 6:47 ` Guenter Roeck
2011-11-01 5:37 Stephen Rothwell
2011-11-01 12:02 ` Mark Brown
2011-11-02 16:43 ` Wim Van Sebroeck
2011-01-10 3:12 Stephen Rothwell
2011-01-10 7:27 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da76007-31f0-404a-a324-dd3068e339c5@app.fastmail.com \
--to=mpearson-lenovo@squebb$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=wim@iguana$(echo .)be \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox