From: Chuck Lever <chuck.lever@oracle•com>
To: Bruce Fields <bfields@fieldses•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
Linux-Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: build warning after merge of the nfsd tree
Date: Thu, 10 May 2018 12:10:18 -0400 [thread overview]
Message-ID: <401FFD11-BAF8-4C2E-8596-0BA734C8EDD5@oracle.com> (raw)
In-Reply-To: <20180510152410.GB29678@fieldses.org>
> On May 10, 2018, at 11:24 AM, Bruce Fields <bfields@fieldses•org> wrote:
>
> On Thu, May 10, 2018 at 10:21:05AM -0400, Chuck Lever wrote:
>>
>>
>>> On May 9, 2018, at 8:42 PM, Stephen Rothwell <sfr@canb•auug.org.au> wrote:
>>>
>>> Hi all,
>>>
>>> After merging the nfsd tree, today's linux-next build (powerpc
>>> ppc64_defconfig) produced this warning:
>>>
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c: In function 'rdma_listen_handler':
>>> net/sunrpc/xprtrdma/svc_rdma_transport.c:299:23: warning: unused variable 'rdma' [-Wunused-variable]
>>> struct svcxprt_rdma *rdma = cma_id->context;
>>> ^~~~
>>
>> Needs to be wrapped with "#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)"
>> Would you like me to send a patch?
>
> Any objection to saving the #if and just going back to writing out
> cma_id->context there?
LGTM
That's not really very useful information anyway, but I decided
to leave this stuff mostly as-is for now. I plan to do something
to fix races between disconnect and device removal at some point.
> I've done that in my tree.
>
> --b.
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index ca9001d73456..05edb18f8ca3 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -544,7 +544,6 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> struct rdma_cm_event *event)
> {
> struct sockaddr *sap = (struct sockaddr *)&cma_id->route.addr.src_addr;
> - struct svcxprt_rdma *rdma = cma_id->context;
> int ret = 0;
>
> trace_svcrdma_cm_event(event, sap);
> @@ -552,7 +551,7 @@ static int rdma_listen_handler(struct rdma_cm_id *cma_id,
> switch (event->event) {
> case RDMA_CM_EVENT_CONNECT_REQUEST:
> dprintk("svcrdma: Connect request on cma_id=%p, xprt = %p, "
> - "event = %s (%d)\n", cma_id, rdma,
> + "event = %s (%d)\n", cma_id, cma_id->context,
> rdma_event_msg(event->event), event->event);
> handle_connect_req(cma_id, &event->param.conn);
> break;
--
Chuck Lever
next prev parent reply other threads:[~2018-05-10 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 0:42 linux-next: build warning after merge of the nfsd tree Stephen Rothwell
2018-05-10 14:21 ` Chuck Lever
2018-05-10 15:24 ` Bruce Fields
2018-05-10 16:10 ` Chuck Lever [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-15 9:27 Stephen Rothwell
2022-02-15 15:08 ` Chuck Lever III
2018-01-18 23:23 Stephen Rothwell
2017-04-03 1:09 Stephen Rothwell
2017-04-03 2:39 ` J. Bruce Fields
2011-03-10 0:53 Stephen Rothwell
2011-03-17 18:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401FFD11-BAF8-4C2E-8596-0BA734C8EDD5@oracle.com \
--to=chuck.lever@oracle$(echo .)com \
--cc=bfields@fieldses$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox