From: "Lorenzo Stoakes (Oracle)" <ljs@kernel•org>
To: Mark Brown <broonie@kernel•org>
Cc: Namjae Jeon <linkinjeon@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
David Hildenbrand <david@kernel•org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Linux Next Mailing List <linux-next@vger•kernel.org>
Subject: Re: linux-next: build failure after merge of the fs-next tree
Date: Fri, 27 Mar 2026 19:27:32 +0000 [thread overview]
Message-ID: <4216ecfd-1407-4bd2-9feb-2b14ea5f26f6@lucifer.local> (raw)
In-Reply-To: <acbY5CCmsk8C95m5@sirena.co.uk>
On Fri, Mar 27, 2026 at 07:22:12PM +0000, Mark Brown wrote:
> Hi all,
>
> After merging the fs-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> /tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
> /tmp/next/build/fs/exfat/file.c:842:13: error: implicit
> declaration of function 'vma_desc_test_flags'; did you mean
> 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> 842 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> | ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
>
> Caused by commit
>
> 9b373eacd6e6c4 (exfat: add iomap buffered I/O support)
>
> from the exfat tree interacting with
>
> 2c3b5ea7028fa (mm: reintroduce vma_desc_test() as a singular flag test)
>
> from one of the mm trees. I have applied a fixup which I can carry as
> needed.
>
> From c4935dbc4b15a9119616ac73b17eff29a7e2ec87 Mon Sep 17 00:00:00 2001
> From: Mark Brown <broonie@kernel•org>
> Date: Fri, 27 Mar 2026 19:08:13 +0000
> Subject: [PATCH] exfat: Fix up merge with mm
>
> /tmp/next/build/fs/exfat/file.c: In function 'exfat_file_mmap_prepare':
> /tmp/next/build/fs/exfat/file.c:842:13: error: implicit
> declaration of function 'vma_desc_test_flags'; did you mean
> 'vma_desc_set_flags'? [-Wimplicit-function-declaration]
> 842 | if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> | ^~~~~~~~~~~~~~~~~~~ vma_desc_set_flags
>
> Signed-off-by: Mark Brown <broonie@kernel•org>
> ---
> fs/exfat/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> index 9a30c32b3a0526..82db5ebaaad7b7 100644
> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -839,7 +839,7 @@ static int exfat_file_mmap_prepare(struct vm_area_desc *desc)
> if (unlikely(exfat_forced_shutdown(file_inode(desc->file)->i_sb)))
> return -EIO;
>
> - if (vma_desc_test_flags(desc, VMA_WRITE_BIT)) {
> + if (vma_desc_test(desc, VMA_WRITE_BIT)) {
LGTM, Cheers!
> struct inode *inode = file_inode(file);
> loff_t from, to;
> int err;
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-03-27 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 19:22 linux-next: build failure after merge of the fs-next tree Mark Brown
2026-03-27 19:27 ` Lorenzo Stoakes (Oracle) [this message]
2026-03-28 1:16 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 14:29 Mark Brown
2026-03-09 23:08 ` Namjae Jeon
2026-03-10 7:21 ` Lorenzo Stoakes (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4216ecfd-1407-4bd2-9feb-2b14ea5f26f6@lucifer.local \
--to=ljs@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=david@kernel$(echo .)org \
--cc=linkinjeon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox