public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt•edu
To: Oleg Nesterov <oleg@redhat•com>
Cc: Sedat Dilek <sedat.dilek@gmail•com>,
	linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Stephen Rothwell <sfr@canb•auug.org.au>,
	Andrew Morton <akpm@linux-foundation•org>,
	Tejun Heo <tj@kernel•org>, Daniel Vetter <daniel.vetter@ffwll•ch>,
	Imre Deak <imre.deak@intel•com>,
	Lukas Czerner <lczerner@redhat•com>,
	Samuel Ortiz <samuel@sortiz•org>,
	Wensong Zhang <wensong@linux-vs•org>,
	Simon Horman <horms@verge•net.au>, Julian Anastasov <ja@ssi•bg>,
	Ralf Baechle <ralf@linux-mips•org>
Subject: Re: linux-next: Tree for Jun 28 [ BISECTED: rsyslog/imklog: High CPU usage ]
Date: Sun, 30 Jun 2013 16:17:07 -0400	[thread overview]
Message-ID: <4823.1372623427@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sun, 30 Jun 2013 20:19:45 +0200." <20130630181945.GA5171@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Sun, 30 Jun 2013 20:19:45 +0200, Oleg Nesterov said:
>
> Not only "__wait_no_timeout(tout) ?:" was wrong, I didn't bother
> to recheck this logic even after I got the "warning: the omitted
> middle operand in ?:" reports.
>
> Sedat, thanks you very much! Any chance you can try the patch below?

I'm not Sedat, but I had the same problem with rsyslog going nuts,
and I can confirm that the patch fixes the problem.  (Had to hand-apply
it, there was some difference of opinion regarding { } on an else)

Feel free to toss on a Tested-By: if this becomes a separate commit...


[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]

  reply	other threads:[~2013-06-30 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-29 21:44 linux-next: Tree for Jun 28 [ BISECTED: rsyslog/imklog: High CPU usage ] Sedat Dilek
2013-06-30 11:50 ` Sedat Dilek
2013-06-30 18:19 ` Oleg Nesterov
2013-06-30 20:17   ` Valdis.Kletnieks [this message]
2013-06-30 21:52     ` Sedat Dilek
2013-06-30 21:49   ` Sedat Dilek
2013-07-01  6:58   ` Stephen Rothwell
2013-07-02 10:15   ` Sedat Dilek
2013-07-02 22:37     ` Oleg Nesterov
2013-07-03  7:24       ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4823.1372623427@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt$(echo .)edu \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=daniel.vetter@ffwll$(echo .)ch \
    --cc=horms@verge$(echo .)net.au \
    --cc=imre.deak@intel$(echo .)com \
    --cc=ja@ssi$(echo .)bg \
    --cc=lczerner@redhat$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=oleg@redhat$(echo .)com \
    --cc=ralf@linux-mips$(echo .)org \
    --cc=samuel@sortiz$(echo .)org \
    --cc=sedat.dilek@gmail$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    --cc=tj@kernel$(echo .)org \
    --cc=wensong@linux-vs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox