Subject: Re: [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath()

From: Andi Kleen <[email-masked]>
Date: Wed, 02 Jul 2008 22:11:06 +0200

> Oh.  I don't care much.

Thanks for the encouraging words.

> But acpi is presently causing build errors and
> is abusing core kernel internals.  Please fix it.
>
> One way would be via printk() and dump_stack().

Here's a patch. Can you use that one instead of Randy's please?

-Andi

Supply warn_on_slow_path() even for the !CONFIG_BUG case

Fix build problem with ACPI for !CONFIG_BUG. Noted by Randy Dunlap.

Signed-off-by: Andi Kleen <[email-masked]>

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 2632328..d0d83b7 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -63,6 +63,9 @@ extern void warn_on_slowpath(const char *file, const int line);
 	unlikely(__ret_warn_on);					\
 })
 #endif
+
+static inline void warn_on_slowpath(const char *file, const int line) {}
+
 #endif
 
 #define WARN_ON_ONCE(condition)	({				\