public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Michal Simek <michal.simek@xilinx•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
	Marc Zyngier <marc.zyngier@arm•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
	Michal Simek <michal.simek@xilinx•com>,
	Mubin Sayyed <mubin.usman.sayyed@xilinx•com>
Subject: Re: linux-next: build failure after merge of the irqchip tree
Date: Mon, 23 Mar 2020 09:08:24 +0100	[thread overview]
Message-ID: <48d3232d-0f1d-42ea-3109-f44bbabfa2e8@xilinx.com> (raw)
In-Reply-To: <20200323175946.7ad497ea@canb.auug.org.au>

Hi Stephen,

On 23. 03. 20 7:59, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the irqchip tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> drivers/irqchip/irq-xilinx-intc.c: In function 'xil_intc_handle_irq':
> drivers/irqchip/irq-xilinx-intc.c:176:10: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
>   176 |    ret = handle_domain_irq(irqc->root_domain, hwirq, regs);
>       |          ^~~~~~~~~~~~~~~~~
>       |          handle_bad_irq
> drivers/irqchip/irq-xilinx-intc.c: In function 'xilinx_intc_of_init':
> drivers/irqchip/irq-xilinx-intc.c:253:3: error: implicit declaration of function 'set_handle_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
>   253 |   set_handle_irq(xil_intc_handle_irq);
>       |   ^~~~~~~~~~~~~~
>       |   generic_handle_irq
> 
> Caused by commit
> 
>   a0789993bf82 ("irqchip/xilinx: Enable generic irq multi handler")
> 
> I have reverted that commit (and commit
> 
>   9c2d4f525c00 ("irqchip/xilinx: Do not call irq_set_default_host()")
> 
> that conflicted with the other revert).
> 

thanks for reporting this.

Marc: I completely forget about this wiring for very ancient platform.
AFAIK Xilinx is not testing this platform for years and would likely the
best to remove support for it completely.
The second option is to get xintc_get_irq() back with note about powerpc
because it won't be that simple change all PPC platform to generic
domain irq handler.
Any other suggestion?

Thanks,
Michal

next prev parent reply	other threads:[~2020-03-23  8:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  6:59 linux-next: build failure after merge of the irqchip tree Stephen Rothwell
2020-03-23  8:08 ` Michal Simek [this message]
2020-03-26  6:36 ` Stephen Rothwell
2020-03-26  7:06   ` Michal Simek
  -- strict thread matches above, loose matches on Subject: below --
2022-09-29 14:31 broonie
2022-09-29 14:40 ` Robin Murphy
2022-09-29 16:22   ` Marc Zyngier
2022-07-11  5:42 Stephen Rothwell
2022-07-11  8:15 ` Marc Zyngier
2022-07-08  4:13 Stephen Rothwell
2022-07-08  7:48 ` Marc Zyngier
2021-06-22  4:15 Stephen Rothwell
2021-04-08  6:35 Stephen Rothwell
2021-04-08  7:56 ` Marc Zyngier
2021-04-08  8:35   ` Jonathan Neuschäfer
2018-10-08  3:06 Stephen Rothwell
2018-10-08  7:06 ` Marc Zyngier
2015-04-13  7:05 Stephen Rothwell
2015-04-13  9:10 ` Stefan Agner
2015-04-13 10:50 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48d3232d-0f1d-42ea-3109-f44bbabfa2e8@xilinx.com \
    --to=michal.simek@xilinx$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=marc.zyngier@arm$(echo .)com \
    --cc=mubin.usman.sayyed@xilinx$(echo .)com \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox