From: Randy Dunlap <randy.dunlap@oracle•com>
To: Greg KH <greg@kroah•com>
Cc: "Sachin P. Sant" <sachinp@in•ibm.com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
ashwin.ganti@gmail•com
Subject: Re: [Staging/p9auth] Feb 26 Next: build failure
Date: Thu, 26 Feb 2009 08:59:32 -0800 [thread overview]
Message-ID: <49A6CA74.7000809@oracle.com> (raw)
In-Reply-To: <20090226155355.GA22194@kroah.com>
Greg KH wrote:
> On Thu, Feb 26, 2009 at 04:40:10PM +0530, Sachin P. Sant wrote:
>> Feb 26 Next tree randconfig build fails with
>>
>> drivers/staging/p9auth/p9auth.c: In function cap_write:
>> drivers/staging/p9auth/p9auth.c:249: error: implicit declaration of
>> function current_uid
>> drivers/staging/p9auth/p9auth.c:261: error: implicit declaration of
>> function prepare_creds
>> drivers/staging/p9auth/p9auth.c:261: warning: assignment makes pointer from
>> integer without a cast
>> drivers/staging/p9auth/p9auth.c:266: error: dereferencing pointer to
>> incomplete type
>> drivers/staging/p9auth/p9auth.c:267: error: dereferencing pointer to
>> incomplete type
>> drivers/staging/p9auth/p9auth.c:268: error: implicit declaration of
>> function commit_creds
>> make[3]: *** [drivers/staging/p9auth/p9auth.o] Error 1
>
> Wierd, I thought cred.h would be pulled in with the current include
> files.
Even if it were, that's not what we want. We want explicit #includes
for macros or structs etc. that are used in a source file.
> With this .config, if you add:
> #include <linux/cred.h>
> to drivers/staging/p9auth/p9auth.c does it solve the build error?
>
> I'll go add it just to be safe :)
It needs both cred.h and sched.h in my testing.
--
~Randy
next prev parent reply other threads:[~2009-02-26 16:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 8:30 linux-next: Tree for February 26 Stephen Rothwell
2009-02-26 11:10 ` [Staging/p9auth] Feb 26 Next: build failure Sachin P. Sant
2009-02-26 15:53 ` Greg KH
2009-02-26 16:59 ` Randy Dunlap [this message]
2009-02-26 17:35 ` Greg KH
2009-02-26 17:42 ` Greg KH
2009-02-27 0:18 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A6CA74.7000809@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=ashwin.ganti@gmail$(echo .)com \
--cc=greg@kroah$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sachinp@in$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox