Subject: Re: linux-next: wireless tree build failure

From: Yang Hongyang <[email-masked]>
Date: Mon, 23 Mar 2009 13:06:37 +0800

David Miller wrote:
> Stephen does this fix the build for you?
> 
> I want to have you test it before I commit because unlike
> some people I'd like to build test changes before submitting
> them anywhere.
> 
> Yang, I am pretty pissed at you, this is beyond unforgivable.
> There is zero excuse for this build regression.

I'm so sorry for that.This is the only patch that I do not build
test for because I think it's too simple.It turns out that I am
totally wrong and I was shamed about that.It's a painful lesson
to me.

> 
> Grumble!
> 
> diff --git a/drivers/net/spider_net.c b/drivers/net/spider_net.c
> index 136d9f1..0288054 100644
> --- a/drivers/net/spider_net.c
> +++ b/drivers/net/spider_net.c
> @@ -2260,18 +2260,18 @@ spider_net_tx_timeout(struct net_device *netdev)
>  }
>  
>  static const struct net_device_ops spider_net_ops = {
> -	.ndo_open		= spider_net_open;
> -	.ndo_stop		= spider_net_stop;
> -	.ndo_start_xmit		= spider_net_xmit;
> -	.ndo_set_multicast_list	= spider_net_set_multi;
> -	.ndo_set_mac_address	= spider_net_set_mac;
> -	.ndo_change_mtu		= spider_net_change_mtu;
> -	.ndo_do_ioctl		= spider_net_do_ioctl;
> -	.ndo_tx_timeout		= spider_net_tx_timeout;
> +	.ndo_open		= spider_net_open,
> +	.ndo_stop		= spider_net_stop,
> +	.ndo_start_xmit		= spider_net_xmit,
> +	.ndo_set_multicast_list	= spider_net_set_multi,
> +	.ndo_set_mac_address	= spider_net_set_mac,
> +	.ndo_change_mtu		= spider_net_change_mtu,
> +	.ndo_do_ioctl		= spider_net_do_ioctl,
> +	.ndo_tx_timeout		= spider_net_tx_timeout,
>  	/* HW VLAN */
>  #ifdef CONFIG_NET_POLL_CONTROLLER
>  	/* poll controller */
> -	.ndo_poll_controller	= spider_net_poll_controller;
> +	.ndo_poll_controller	= spider_net_poll_controller,
>  #endif /* CONFIG_NET_POLL_CONTROLLER */
>  };
>  
> 
> 

-- 
Regards
Yang Hongyang

◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆
◆
◇   富士通邀请您参加“地球一小时”活动 
◆      http://www.fujitsu.com/cn/about/earth_hour.html
◇   
◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆◇◆