Subject: Re: linux-next: usb tree build failure

From: Randy Dunlap <[email-masked]>
Date: Thu, 30 Apr 2009 09:27:36 -0700

Greg KH wrote:
> On Wed, Apr 29, 2009 at 10:53:30AM -0700, Randy Dunlap wrote:
>> Greg KH wrote:
>>> On Wed, Apr 29, 2009 at 08:44:47AM -0700, Randy Dunlap wrote:
>>>> Greg KH wrote:
>>>>> On Wed, Apr 29, 2009 at 08:18:20AM -0700, Randy Dunlap wrote:
>>>>>> Stephen Rothwell wrote:
>>>>>>> Hi Greg,
>>>>>>>
>>>>>>> Today's linux-next build (powerpc allyesconfig) failed like this:
>>>>>>>
>>>>>>> drivers/usb/built-in.o: In function `.handle_event':
>>>>>>> (.text+0x67dd0): multiple definition of `.handle_event'
>>>>>>> drivers/pcmcia/built-in.o:(.text+0xcfcc): first defined here
>>>>>>> drivers/usb/built-in.o: In function `handle_event':
>>>>>>> (.opd+0x5bc8): multiple definition of `handle_event'
>>>>>>> drivers/pcmcia/built-in.o:(.opd+0xed0): first defined here
>>>>>> There's also this one:
>>>>>>
>>>>>> drivers/usb/host/xhci-mem.c:46: error: implicit declaration of function 'dma_pool_alloc'
>>>>>> drivers/usb/host/xhci-mem.c:69: error: implicit declaration of function 'dma_pool_free'
>>>>>> drivers/usb/host/xhci-mem.c:578: error: implicit declaration of function 'dma_pool_destroy'
>>>>>> drivers/usb/host/xhci-mem.c:657: error: implicit declaration of function 'dma_pool_create'
>>>>>>
>>>>>> That file needs to
>>>>>> #include <linux/dmapool.h>
>>>>> What arch had this problem?
>>>> i386
>>> I can't duplicate this here, care to attach a .config?
>> attached.  But you don't need to be able to duplicate it.
>>
>> The source file obviously uses those interfaces, so it should
>> include that header file.
> 
> Ah, it's a PCI config issue, a Kbuild change will fix this.

So I noticed, but it should still #include the header file since those
interfaces are used.

-- 
~Randy