From: Sebastian Haas <haas@ems-wuensche•com>
To: Randy Dunlap <rdunlap@xenotime•net>
Cc: LKML <linux-kernel@vger•kernel.org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, Greg KH <gregkh@suse•de>
Subject: Re: [PATCH -next] cpc-usb: fix PROC_FS dependency
Date: Mon, 25 May 2009 06:51:48 +0200 [thread overview]
Message-ID: <4A1A23E4.3070604@ems-wuensche.com> (raw)
In-Reply-To: <4A16D495.9040301@xenotime.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Randy Dunlap schrieb:
> Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle•com>
>>
>> The proper way to check for and enforce a kconfig symbol
>> dependency is via Kconfig files, not by using #error in
>> a source file followed by 9 other compile errors.
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle•com>
>> Cc: Sebastian Haas <haas@ems-wuensche•com>
>> ---
>> drivers/staging/cpc-usb/Kconfig | 2 +-
>> drivers/staging/cpc-usb/cpc-usb_drv.c | 10 +---------
>> 2 files changed, 2 insertions(+), 10 deletions(-)
>>
>> --- linux-next-20090522.orig/drivers/staging/cpc-usb/cpc-usb_drv.c
>> +++ linux-next-20090522/drivers/staging/cpc-usb/cpc-usb_drv.c
>> @@ -27,12 +27,8 @@
>> #include <linux/completion.h>
>> #include <asm/uaccess.h>
>> #include <linux/usb.h>
>> -
>> #include <linux/version.h>
>> -
>> -#ifdef CONFIG_PROC_FS
>> -# include <linux/proc_fs.h>
>> -#endif
>> +#include <linux/proc_fs.h>
>>
>> #include "cpc.h"
>>
>> @@ -57,10 +53,6 @@ MODULE_LICENSE("GPL v2");
>> #define USB_CPCUSB_M16C_PRODUCT_ID 0x0888
>> #define USB_CPCUSB_LPC2119_PRODUCT_ID 0x0444
>>
>> -#ifndef CONFIG_PROC_FS
>> -#error "PROCFS needed"
>> -#endif
>> -
>> #define CPC_USB_PROC_DIR CPC_PROC_DIR "cpc-usb"
>>
>> static struct proc_dir_entry *procDir;
>> --- linux-next-20090522.orig/drivers/staging/cpc-usb/Kconfig
>> +++ linux-next-20090522/drivers/staging/cpc-usb/Kconfig
>> @@ -1,4 +1,4 @@
>> config USB_CPC
>> tristate "CPC CAN USB driver"
>> - depends on USB
>> + depends on USB && PROC_FS
>> default n
>
> BTW, I'm surprised that there is no NET or CAN dependency here.
Yes, you are right. But there are no dependencies yet. As soon as
the driver starts to support SocketCAN, we need to add this
dependency.
- --
Mit freundlichen Gruessen/Best Regards,
Sebastian Haas
Software Entwicklung/Software Development
Phone: +49-9451-9432-22
Fax : +49-9451-9432-12
Email: haas@ems-wuensche•com
Web : www.ems-wuensche.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkoaI9sACgkQpqRB8PJG7XzKAgCfWhjQeeFG+qXLoOQHM0hy0sw2
iK8An08cPNYEP5qEA/ex5KGjZm71keBq
=Fxlt
-----END PGP SIGNATURE-----
--
EMS Dr. Thomas Wuensche e.K.
Sonnenhang 3
85304 Ilmmuenster
HRA Neuburg a.d. Donau, HR-Nr. 70.106
Phone: +49-8441-490260
Fax : +49-8441-81860
http://www.ems-wuensche.com
prev parent reply other threads:[~2009-05-25 5:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 8:51 linux-next: Tree for May 22 Stephen Rothwell
2009-05-22 16:05 ` linux-next: Tree for May 22 (staging/) Randy Dunlap
2009-05-22 16:30 ` [PATCH -next] cpc-usb: fix PROC_FS dependency Randy Dunlap
2009-05-22 16:36 ` Randy Dunlap
2009-05-25 4:51 ` Sebastian Haas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1A23E4.3070604@ems-wuensche.com \
--to=haas@ems-wuensche$(echo .)com \
--cc=gregkh@suse$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@xenotime$(echo .)net \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox