From: "Jan Beulich" <JBeulich@novell•com>
To: Tony Luck <tony.luck@intel•com>, Tejun Heo <tj@kernel•org>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
akpm <akpm@linux-foundation•org>,
Randy Dunlap <randy.dunlap@oracle•com>,
Sam Ravnborg <sam@ravnborg•org>,
Andreas Gruenbacher <agruen@suse•de>,
"linux-ia64@vger•kernel.org" <linux-ia64@vger•kernel.org>,
LKML <linux-kernel@vger•kernel.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>
Subject: Re: [PATCH -next] ia64/sn: fix percpu warnings
Date: Fri, 30 Oct 2009 16:05:24 +0000 [thread overview]
Message-ID: <4AEB1CD4020000780001CD66@vpn.id2.novell.com> (raw)
In-Reply-To: <4AE9B812.2080307@kernel.org>
>>> Tejun Heo <tj@kernel•org> 29.10.09 16:43 >>>
>So, the problem is that genksyms can't understand the following.
>
> __typeof__(int [10]) my_ar;
> EXPORT_SYMBOL(my_ar);
In fact almost no use of typeof() works with genksyms: Out of
#include <linux/module.h>
extern int x;
#define export(t, n) typeof(t) export_##n; EXPORT_SYMBOL(export_##n)
export(x, a);
export(&x, b);
export(int, c);
export(int*, d);
export(int**, e);
export(int[4], f);
export(typeof(x), g);
export(typeof(&x), h);
export(typeof(x)*, i);
only c and d get a non-zero CRC. This is clearly due to the naive parsing
scripts/genksyms/parse.y does:
type_specifier:
simple_type_specifier
| cvar_qualifier
| TYPEOF_KEYW '(' decl_specifier_seq '*' ')'
| TYPEOF_KEYW '(' decl_specifier_seq ')'
...
>Would it be difficult to teach it how to parse it?
For someone familiar with bison/yacc this would seem not very difficult
a job, but as far as I'm concerned this is not something I would feel
comfortable trying to fix. Of course one could go the simplistic route
and just add the array case here, but imo this wouldn't be the right
way to deal with it.
Jan
next prev parent reply other threads:[~2009-10-30 16:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 5:34 linux-next: Tree for October 14 Stephen Rothwell
2009-10-14 15:55 ` Randy Dunlap
2009-10-14 21:12 ` Stephen Rothwell
2009-10-14 22:10 ` [PATCH -next] ia64/sn: fix percpu warnings Randy Dunlap
2009-10-15 1:33 ` Tejun Heo
2009-10-26 18:24 ` Tony Luck
2009-10-26 23:35 ` Luck, Tony
2009-10-28 15:03 ` Tejun Heo
2009-10-28 16:24 ` Luck, Tony
2009-10-28 16:37 ` Tejun Heo
2009-10-28 16:58 ` Luck, Tony
2009-10-28 22:23 ` Luck, Tony
2009-10-29 14:43 ` Tejun Heo
2009-10-29 15:43 ` Tejun Heo
2009-10-30 16:05 ` Jan Beulich [this message]
2009-10-14 22:10 ` [PATCH -next] kvm: fix ia64 printk formats Randy Dunlap
2009-10-15 2:32 ` Zhang, Xiantao
2009-10-15 1:17 ` [PATCH -next] vmxnet: fix 2 build problems Randy Dunlap
2009-10-15 2:00 ` [Pv-drivers] " Bhavesh Davda
2009-10-15 3:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEB1CD4020000780001CD66@vpn.id2.novell.com \
--to=jbeulich@novell$(echo .)com \
--cc=agruen@suse$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tj@kernel$(echo .)org \
--cc=tony.luck@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox