public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jonathan Cameron <jic23@cam•ac.uk>
To: Paul Mundt <lethal@linux-sh•org>
Cc: Greg Kroah-Hartman <gregkh@suse•de>,
	devel@driverdev•osuosl.org, linux-next@vger•kernel.org
Subject: Re: [PATCH -next] staging: iio: Fix up the module build.
Date: Thu, 05 Nov 2009 11:06:31 +0000	[thread overview]
Message-ID: <4AF2B1B7.506@cam.ac.uk> (raw)
In-Reply-To: <20091105060900.GD26910@linux-sh.org>

Good catch.

Thanks

Acked-by: Jonathan Cameron <jic23@cam•ac.uk>
> Both the max1363 and lis3l02dq modules rely on IIO trigger support in
> their ring buffer implementations, which is presently a separate config
> option. In the case of IIO_RING_BUFFER=y and IIO_TRIGGER=n, we end up
> with the following:
> 
> ERROR: "iio_trigger_attach_poll_func" [drivers/staging/iio/adc/max1363.ko] undefined!
> ERROR: "iio_trigger_dettach_poll_func" [drivers/staging/iio/adc/max1363.ko] undefined!
> ERROR: "iio_trigger_unregister" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_trigger_notify_done" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_trigger_read_name" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_trigger_poll" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_trigger_attach_poll_func" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_trigger_register" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_free_trigger" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_trigger_dettach_poll_func" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> ERROR: "iio_allocate_trigger" [drivers/staging/iio/accel/lis3l02dq.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> This adds an IIO_TRIGGER select for these two drivers conditional on
> IIO ring buffer support. Caught with an SH randconfig in -next.
> 
> Signed-off-by: Paul Mundt <lethal@linux-sh•org>
> 
> ---
> 
>  drivers/staging/iio/accel/Kconfig |    1 +
>  drivers/staging/iio/adc/Kconfig   |    1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/iio/accel/Kconfig b/drivers/staging/iio/accel/Kconfig
> index fef3da4..c245644 100644
> --- a/drivers/staging/iio/accel/Kconfig
> +++ b/drivers/staging/iio/accel/Kconfig
> @@ -13,6 +13,7 @@ config KXSD9
>  config LIS3L02DQ
>  	tristate "ST Microelectronics LIS3L02DQ Accelerometer Driver"
>  	depends on SPI
> +	select IIO_TRIGGER if IIO_RING_BUFFER
>  	help
>  	  Say yes here to build SPI support for the ST microelectronics
>  	  accelerometer. The driver supplies direct access via sysfs files
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index b8c2858..a2f1626 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -6,6 +6,7 @@ comment "Analog to digital convertors"
>  config MAX1363
>  	tristate "MAXIM max1363 ADC driver"
>  	depends on I2C
> +	select IIO_TRIGGER if IIO_RING_BUFFER
>  	help
>  	  Say yes here to build support for many MAXIM i2c analog to digital
>  	  convertors (ADC). (max1361, max1362, max1363, max1364, max1136,

next prev parent reply	other threads:[~2009-11-05 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  6:09 [PATCH -next] staging: iio: Fix up the module build Paul Mundt
2009-11-05 11:06 ` Jonathan Cameron [this message]
2009-11-05 17:02   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF2B1B7.506@cam.ac.uk \
    --to=jic23@cam$(echo .)ac.uk \
    --cc=devel@driverdev$(echo .)osuosl.org \
    --cc=gregkh@suse$(echo .)de \
    --cc=lethal@linux-sh$(echo .)org \
    --cc=linux-next@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox