Subject: Re: linux-next: Tree for December 16 (amd64_edac)

From: "H. Peter Anvin" <[email-masked]>
Date: Wed, 16 Dec 2009 09:32:45 -0800

On 12/16/2009 09:24 AM, Randy Dunlap wrote:
> On Wed, 16 Dec 2009 18:32:12 +1100 Stephen Rothwell wrote:
> 
>> Hi all,
>>
>> My usual call for calm: please do not put stuff destined for 2.6.34 into
>> linux-next trees until after 2.6.33-rc1.
>>
>> Changes since 20091215:
> 
> 
> When CONFIG_SMP=n, CONFIG_X86_MSR=m:
> 
> ERROR: "msrs_free" [drivers/edac/amd64_edac_mod.ko] undefined!
> ERROR: "msrs_alloc" [drivers/edac/amd64_edac_mod.ko] undefined!
> 
> 
> Should EDAC_AMD64 also depend on SMP?
> 

That seems absurd... more likely msrs_free/msrs_alloc should not be
SMP-specific, or stubs need to be provided.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.