Subject: Re: linux-next: build failure after merge of the v4l-dvb tree

From: Mauro Carvalho Chehab <[email-masked]>
Date: Fri, 05 Feb 2010 13:02:38 -0200

Stephen Rothwell wrote:
> Hi Mauro,
> 
> After merging the scsi-post-merge tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/media/dvb/ngene/ngene-core.c: In function 'ngene_release_buffers':
> drivers/media/dvb/ngene/ngene-core.c:1443: error: implicit declaration of function 'vfree'
> drivers/media/dvb/ngene/ngene-core.c: In function 'ngene_get_buffers':
> drivers/media/dvb/ngene/ngene-core.c:1454: error: implicit declaration of function 'vmalloc'
> drivers/media/dvb/ngene/ngene-core.c:1454: warning: assignment makes pointer from integer without a cast
> drivers/media/dvb/ngene/ngene-core.c:1461: warning: assignment makes pointer from integer without a cast
> drivers/media/dvb/ngene/ngene-core.c:1467: warning: assignment makes pointer from integer without a cast
> drivers/media/dvb/ngene/ngene-core.c: In function 'ngene_probe':
> drivers/media/dvb/ngene/ngene-core.c:1836: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit b54c755d6263efe376f3dfc8c72c8e7b4fb4f4c1 ("V4L/DVB:
> ngene: Initial check-in").
> 
> I added the following patch for today.
> 
> From: Stephen Rothwell <[email-masked]>
> Date: Fri, 5 Feb 2010 16:46:47 +1100
> Subject: [PATCH] V4L/DVB: using vmalloc requires include linux/vmalloc.h
> 
> Signed-off-by: Stephen Rothwell <[email-masked]>
> ---
>  drivers/media/dvb/ngene/ngene-core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index ea610e4..cb5982e 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -41,6 +41,7 @@
>  #include <linux/version.h>
>  #include <linux/byteorder/generic.h>
>  #include <linux/firmware.h>
> +#include <linux/vmalloc.h>
>  
>  #include "ngene.h"
>  
Thanks for the patch. It looks sane to me. I'm adding it on my linux-next tree.

Cheers,
Mauro.

-- 

Cheers,
Mauro