Subject: Re: [PATCH] sysfs: Don't use enums in inline function declaration.

From: Randy Dunlap <[email-masked]>
Date: Wed, 05 May 2010 15:05:59 -0700

On 05/05/10 14:54, [email-masked] wrote:
> 
> It appears gcc can't cope with using an enum that is only declared in
> an inline function declaration, that doesn't even use the variable
> that is so declared.
> 
> Avoid the silliness and replace the enum with an int, and make gcc
> happy.
> 
> Signed-off-by: Eric W. Biederman <[email-masked]>

Acked-by: Randy Dunlap <[email-masked]>

Thanks, Eric.

> ---
>  include/linux/sysfs.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index e58ca1c..17cbeb7 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -318,7 +318,7 @@ static inline void sysfs_put(struct sysfs_dirent *sd)
>  {
>  }
>  
> -static inline void sysfs_exit_ns(enum kobj_ns_type type, const void *tag)
> +static inline void sysfs_exit_ns(int type, const void *tag)
>  {
>  }
>  

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***