Subject: -next June 21: WARNING: at include/linux/tty.h

From: Sachin Sant <[email-masked]>
Date: Tue, 22 Jun 2010 10:55:54 +0530

With next-20100621 on a x86_64 box came across this warning :

TCP cubic registered
registered taskstats version 1
------------[ cut here ]------------
WARNING: at include/linux/tty.h:589 tty_open+0x76/0x57a()
Hardware name: BladeCenter LS21 -[79716AA]-
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.35-rc3-autotest-next-20100621 #1
Call Trace:
 [<ffffffff812428d8>] ? tty_open+0x76/0x57a
 [<ffffffff8103cf39>] warn_slowpath_common+0x80/0xae
 [<ffffffff8103cf7c>] warn_slowpath_null+0x15/0x17
 [<ffffffff812428d8>] tty_open+0x76/0x57a
 [<ffffffff810d4544>] ? exact_match+0x0/0x9
 [<ffffffff810d491f>] chrdev_open+0x133/0x152
 [<ffffffff810d47ec>] ? chrdev_open+0x0/0x152
 [<ffffffff810d07b4>] __dentry_open+0x140/0x252
 [<ffffffff810d0990>] nameidata_to_filp+0x3e/0x4f
 [<ffffffff810db588>] do_last+0x51a/0x643
 [<ffffffff810dd621>] do_filp_open+0x23d/0x5f8
 [<ffffffff810c1ba8>] ? slab_node+0x3c/0x78
 [<ffffffff810d05a1>] do_sys_open+0x5a/0xf0
 [<ffffffff810d0660>] sys_open+0x1b/0x1d
 [<ffffffff818e66fc>] kernel_init+0x1b3/0x220
 [<ffffffff810036d4>] kernel_thread_helper+0x4/0x10
 [<ffffffff818e6549>] ? kernel_init+0x0/0x220
 [<ffffffff810036d0>] ? kernel_thread_helper+0x0/0x10
---[ end trace 108cb769a1c0e534 ]---

This warning seem to have been introduced with next-20100617.
The corresponding code is :

585 static inline void tty_lock(void) __acquires(kernel_lock)
586 {
587 #ifdef CONFIG_LOCK_KERNEL
588         /* kernel_locked is 1 for !CONFIG_LOCK_KERNEL */
589         WARN_ON(kernel_locked());
590 #endif
591         lock_kernel();
592 }

which was added by commit 01510c869f9..

tty: replace BKL with a new tty_lock

Thanks
-Sachin

-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------