From: Randy Dunlap <randy.dunlap@oracle•com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
Cc: mchehab@infradead•org, mingo@elte•hu, sfr@canb•auug.org.au,
linux-next@vger•kernel.org
Subject: Re: [PATCH] uvc: Fix multiple symbols definitions with UVC gadget and host drivers
Date: Mon, 12 Jul 2010 14:12:45 -0700 [thread overview]
Message-ID: <4C3B854D.9050201@oracle.com> (raw)
In-Reply-To: <1278789185-24989-1-git-send-email-laurent.pinchart@ideasonboard.com>
Laurent Pinchart wrote:
> The UVC gadget driver borrowed code from the UVC host driver without
> changing the symbol names. This results in a namespace clash with
> multiple definitions of several symbols when compiling both drivers in
> the kernel.
>
> Make all generic UVC functions and variables static in the UVC gadget
> driver, as the symbols are not referenced outside of the gadget driver.
> Rename the uvc_trace_param global variable to uvc_gadget_trace_param.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
Acked-by: Randy Dunlap <randy.dunlap@oracle•com>
Thanks.
> ---
> drivers/usb/gadget/f_uvc.c | 4 +-
> drivers/usb/gadget/uvc.h | 10 +--
> drivers/usb/gadget/uvc_queue.c | 153 +++++++++++++++++++++-------------------
> drivers/usb/gadget/uvc_queue.h | 20 -----
> drivers/usb/gadget/uvc_v4l2.c | 2 +-
> drivers/usb/gadget/uvc_video.c | 6 +-
> drivers/usb/gadget/webcam.c | 4 +-
> 7 files changed, 89 insertions(+), 110 deletions(-)
prev parent reply other threads:[~2010-07-12 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 19:13 [PATCH] uvc: Fix multiple symbols definitions with UVC gadget and host drivers Laurent Pinchart
2010-07-12 21:12 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3B854D.9050201@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mchehab@infradead$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox