public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6•in-berlin.de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux1394-devel@lists•sourceforge.net,
	linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: build failure after merge of the ieee1394 tree
Date: Tue, 27 Jul 2010 10:07:40 +0200	[thread overview]
Message-ID: <4C4E93CC.5030109@s5r6.in-berlin.de> (raw)
In-Reply-To: <20100727114839.06d25309.sfr@canb.auug.org.au>

Stephen Rothwell wrote:
> After merging the ieee1394 tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/firewire/nosy.c: In function 'packet_buffer_get':
> drivers/firewire/nosy.c:154: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/firewire/nosy.c:154: error: implicit declaration of function 'signal_pending'
> drivers/firewire/nosy.c:154: error: implicit declaration of function 'schedule'
> drivers/firewire/nosy.c: In function 'packet_buffer_put':
> drivers/firewire/nosy.c:221: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/firewire/nosy.c: In function 'remove_card':
> drivers/firewire/nosy.c:514: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> 
> Forgot to include something?
> 
> I have used the ieee1394 tree from next-20100726 for today.

Oh right.  Every user of <linux/wait.h> must also include
<linux/sched.h>, unfortunately.  I saw the same problem months ago with
another driver, I wonder why I did not catch it this time.

I will fix it later today.  This code is in a topic branch for a new
driver; I will rewrite that branch to stay fully bisectable.
-- 
Stefan Richter
-=====-==-=- -=== ==-==
http://arcgraph.de/sr/

  reply	other threads:[~2010-07-27  8:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27  1:48 linux-next: build failure after merge of the ieee1394 tree Stephen Rothwell
2010-07-27  8:07 ` Stefan Richter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-30  2:24 Stephen Rothwell
2023-05-30 10:44 ` Takashi Sakamoto
2024-02-02  0:16 Stephen Rothwell
2024-02-02  1:04 ` Takashi Sakamoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C4E93CC.5030109@s5r6.in-berlin.de \
    --to=stefanr@s5r6$(echo .)in-berlin.de \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=linux1394-devel@lists$(echo .)sourceforge.net \
    --cc=sfr@canb$(echo .)auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox