Subject: Re: [PATCH -next] optprobes: fix kconfig depends/selects

From: Masami Hiramatsu <[email-masked]>
Date: Tue, 17 Aug 2010 23:55:27 +0900

Randy Dunlap wrote:
> From: Randy Dunlap <[email-masked]>
> 
> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.

Indeed, Thanks for pointing it!

Signed-off-by: Masami Hiramatsu <[email-masked]>

> 
> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc:	Ananth N Mavinakayanahalli <[email-masked]>
> Cc:	Anil S Keshavamurthy <[email-masked]>
> Cc:	"David S. Miller" <[email-masked]>
> Cc:	Masami Hiramatsu <[email-masked]>
> ---
>  arch/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20100810.orig/arch/Kconfig
> +++ linux-next-20100810/arch/Kconfig
> @@ -45,6 +45,8 @@ config OPTPROBES
>  	def_bool y
>  	depends on KPROBES && HAVE_OPTPROBES
>  	depends on !PREEMPT
> +	depends on DEBUG_KERNEL
> +	select KALLSYMS
>  	select KALLSYMS_ALL
>  
>  config HAVE_EFFICIENT_UNALIGNED_ACCESS