Subject: Re: [-next Sept 9] S309 Build break (mm/percpu.c)

From: Sachin Sant <[email-masked]>
Date: Fri, 10 Sep 2010 11:39:33 +0530

Tejun Heo wrote:
> Commit bbddff05 (percpu: use percpu allocator on UP too) incorrectly
> excluded pcpu_build_alloc_info() on SMP configurations which use
> generic setup_per_cpu_area() like s390.  The config ifdefs are
> becoming confusing.  Fix and clean it up by,
>
> * Move pcpu_build_alloc_info() right on top of its two users -
>   pcpu_{embed|page}_first_chunk() which are already in CONFIG_SMP
>   block.
>
> * Define BUILD_{EMBED|PAGE}_FIRST_CHUNK which indicate whether each
>   first chunk function needs to be included and use them to control
>   inclusion of the three functions to reduce confusion.
>
> Signed-off-by: Tejun Heo <[email-masked]>
> Reported-by: Sachin Sant <[email-masked]>
> ---
> Can you please test this patch?
>   
Tested the patch against yesterday's next release(20100909). Works fine.

Thanks Tejun.

Regards
-Sachin

-- 

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------