Subject: Re: [PATCH] rtlwifi: usb parts should depend on CONFIG_USB

From: Larry Finger <[email-masked]>
Date: Mon, 28 Feb 2011 15:01:17 -0600

On 02/28/2011 01:48 PM, John W. Linville wrote:
> ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
>
> The USB-part of rtlwifi should depend on CONFIG_USB.
>
> Reported-by: Geert Uytterhoeven<[email-masked]>
> Signed-off-by: John W. Linville<[email-masked]>
> ---
>   drivers/net/wireless/rtlwifi/Makefile |    7 +++++--
>   1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/Makefile b/drivers/net/wireless/rtlwifi/Makefile
> index 9192fd5..27355be 100644
> --- a/drivers/net/wireless/rtlwifi/Makefile
> +++ b/drivers/net/wireless/rtlwifi/Makefile
> @@ -7,8 +7,7 @@ rtlwifi-objs	:=		\
>   		efuse.o		\
>   		ps.o		\
>   		rc.o		\
> -		regd.o		\
> -		usb.o
> +		regd.o
>
>   rtl8192c_common-objs +=		\
>
> @@ -16,6 +15,10 @@ ifeq ($(CONFIG_PCI),y)
>   rtlwifi-objs	+= pci.o
>   endif
>
> +ifeq ($(CONFIG_USB),y)
> +rtlwifi-objs	+= usb.o
> +endif
> +
>   obj-$(CONFIG_RTL8192C_COMMON)	+= rtl8192c/
>   obj-$(CONFIG_RTL8192CE)		+= rtl8192ce/
>   obj-$(CONFIG_RTL8192CU)		+= rtl8192cu/

This fails on my system as CONFIG_USB=m, not y.

Larry