Subject: Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES

From: Randy Dunlap <[email-masked]>
Date: Mon, 23 May 2011 09:21:54 -0700

On 05/22/11 20:35, viresh kumar wrote:
> On 05/23/2011 06:02 AM, Randy Dunlap wrote:
>> From: Randy Dunlap <[email-masked]>
>>
>> Fix kconfig unmet dependency warning:
>>
>> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
>>
>> Signed-off-by: Randy Dunlap <[email-masked]>
>> Cc: Viresh Kumar <[email-masked]>
>> ---
>>  drivers/ata/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20110520.orig/drivers/ata/Kconfig
>> +++ linux-next-20110520/drivers/ata/Kconfig
>> @@ -313,6 +313,7 @@ config PATA_AMD
>>  
>>  config PATA_ARASAN_CF
>>  	tristate "ARASAN CompactFlash PATA Controller Support"
>> +	depends on DMADEVICES
>>  	select DMA_ENGINE
> 
> Randy,
> 
> I think we can also remove this "select DMA_ENGINE" line.

In that case, the newly added "depends on" line is not needed either,
since the "select DMA_ENGINE" is what causes the kconfig warning message.

> Otherwise, it looks fine.
> 
> Acked-by: Viresh Kumar <[email-masked]>
> 

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***