From: J Freyensee <james_p_freyensee@linux•intel.com>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
randy.dunlap@oracle•com, sfr@canb•auug.org.au,
christophe.guerard@intel•com, pranav.k.sanghadia@intel•com
Subject: Re: [PATCH] PTI implicit declaration fix.
Date: Mon, 11 Jul 2011 09:10:53 -0700 [thread overview]
Message-ID: <4E1B208D.1000708@linux.intel.com> (raw)
In-Reply-To: <CAMuHMdV5OC6ENMK9uOXZBv3Z3MrOMiu0P6az5baM9jdRFwSAvA@mail.gmail.com>
On 07/09/2011 01:08 AM, Geert Uytterhoeven wrote:
> On Fri, Jul 8, 2011 at 23:34,<james_p_freyensee@linux•intel.com> wrote:
>> From: J Freyensee<james_p_freyensee@linux•intel.com>
>>
>> In a certain compile configuration, functions like
>> 'kmalloc' and 'copy_from_user' were coming up as
>> implicit errors. This patch adds slab.h and
>> uaccess.h to the driver.
>>
>> Reported-by: Geert Uytterhoeven<geert@linux-m68k•org>
>> Acked-by: Geert Uytterhoeven<geert@linux-m68k•org>
>
> Please don't add "Acked-by" lines before people have ack'ed your patches.
>
Okay...so should I re-send this patch out without the Acked-by in it?
Or is it okay this time and next time please do this?
>> Signed-off-by: J Freyensee<james_p_freyensee@linux•intel.com>
>> ---
>> drivers/misc/pti.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c
>> index 8653bd0..4ba4e5f 100644
>> --- a/drivers/misc/pti.c
>> +++ b/drivers/misc/pti.c
>> @@ -22,6 +22,8 @@
>> */
>>
>> #include<linux/init.h>
>> +#include<linux/slab.h>
>> +#include<linux/uaccess.h>
>> #include<linux/sched.h>
>> #include<linux/interrupt.h>
>> #include<linux/console.h>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2011-07-11 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 21:34 [PATCH] PTI implicit declaration fix james_p_freyensee
2011-07-09 8:08 ` Geert Uytterhoeven
2011-07-11 16:10 ` J Freyensee [this message]
2011-07-11 16:57 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1B208D.1000708@linux.intel.com \
--to=james_p_freyensee@linux$(echo .)intel.com \
--cc=christophe.guerard@intel$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=pranav.k.sanghadia@intel$(echo .)com \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox