Subject: Re: [PATCH] drivers/media: fix dependencies in video mt9t001/mt9p031

From: Mauro Carvalho Chehab <[email-masked]>
Date: Sat, 08 Oct 2011 07:52:57 -0300

Em 06-10-2011 00:02, Stephen Rothwell escreveu:
> Hi Mauro,
>
> On Fri, 30 Sep 2011 15:38:13 -0700 Randy Dunlap<[email-masked]>  wrote:
>>
>> On 09/30/11 14:34, Paul Gortmaker wrote:
>>> Both mt9t001.c and mt9p031.c have two identical issues, those
>>> being that they will need module.h inclusion for the upcoming
>>> cleanup going on there, and that their dependencies don't limit
>>> selection of configs that will fail to compile as follows:
>>>
>>> drivers/media/video/mt9p031.c:457: error: implicit declaration of function ‘v4l2_subdev_get_try_crop’
>>> drivers/media/video/mt9t001.c:787: error: ‘struct v4l2_subdev’ has no member named ‘entity’
>>>
>>> The related config options are CONFIG_MEDIA_CONTROLLER and
>>> CONFIG_VIDEO_V4L2_SUBDEV_API.  Looking at the code, it appears
>>> that the driver was never intended to work without these enabled,
>>> so add a dependency on CONFIG_VIDEO_V4L2_SUBDEV_API, which in
>>> turn already has a dependency on CONFIG_MEDIA_CONTROLLER.
>>>
>>> Reported-by: Randy Dunlap<[email-masked]>
>>> Signed-off-by: Paul Gortmaker<[email-masked]>
>>
>> Acked-by: Randy Dunlap<[email-masked]>
>
> Ping?
>
Sorry, I was assuming that this patch would be going together with the
other module.h trees. I'll apply it on my tree.

Thanks,
Mauro