Subject: Re: linux-next: Tree for Nov 16 (infiniband: ib_srpt.c)

From: Randy Dunlap <rdunlap-/[email-masked]>
Date: Wed, 16 Nov 2011 18:34:09 -0800

On 11/15/2011 06:33 PM, Stephen Rothwell wrote:
> Hi all,

When CONFIG_BUG is not enabled:

next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c: In function 'srpt_cm_dreq_recv':
next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c:2761:3: error: implicit declaration of function '__WARN'

jbd2 has a similar issue (still unpatched).  One of the comments in that thread
was that ext4 probably should use WARN_ON() instead of __WARN().

Or (Arnd said):
Hmm, my feeling is that we shouldn't do that either, and that jbd2 should
be changed. If we want a function that does what __WARN() does today, we
should probably make a conscious decision about what we want it to be called
and not have it start with "__". <end Arnd>

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email-masked]
More majordomo info at  http://vger.kernel.org/majordomo-info.html