Subject: Re: [PATCH -next] ext4: get rid of compile warning

From: Randy Dunlap <[email-masked]>
Date: Mon, 20 Feb 2012 08:00:05 -0800

On 02/20/2012 04:56 AM, Heiko Carstens wrote:
> Get rid of this one:
>
> fs/ext4/balloc.c: In function 'ext4_wait_block_bitmap':
> fs/ext4/balloc.c:405:3: warning: format '%llu' expects argument of
>    type 'long long unsigned int', but argument 6 has type 'sector_t' [-Wformat]
>
> Happens because sector_t is u64 (unsigned long long) or unsigned long
> dependent on CONFIG_64BIT.
>
> Signed-off-by: Heiko Carstens<[email-masked]>

I sent the same patch on Jan. 30.  I wonder what happened to it?

Acked-by: Randy Dunlap <[email-masked]>

Thanks.

> ---
>   fs/ext4/balloc.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 95c87ab..c355890 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -404,7 +404,7 @@ int ext4_wait_block_bitmap(struct super_block *sb, ext4_group_t block_group,
>   	if (!buffer_uptodate(bh)) {
>   		ext4_error(sb, "Cannot read block bitmap - "
>   			   "block_group = %u, block_bitmap = %llu",
> -			   block_group, bh->b_blocknr);
> +			   block_group, (unsigned long long) bh->b_blocknr);
>   		return 1;
>   	}
>   	/* Panic or remount fs read-only if block bitmap is invalid */

-- 
~Randy