From: "H. Peter Anvin" <hpa@zytor•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Paul Gortmaker <paul.gortmaker@windriver•com>,
mingo@redhat•com, linux-kernel@vger•kernel.org, arnd@arndb•de,
dhowells@redhat•com, tglx@linutronix•de,
linux-tip-commits@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: [tip:x86/asm] bitops: Optimise get_order()
Date: Thu, 01 Mar 2012 13:02:47 -0800 [thread overview]
Message-ID: <4F4FE3F7.5030508@zytor.com> (raw)
In-Reply-To: <20120301113106.020c3ad0560425970c9de34e@canb.auug.org.au>
David, could you make a fix for this?
-hpa
On 02/29/2012 04:31 PM, Stephen Rothwell wrote:
> On Wed, 29 Feb 2012 15:29:04 -0500 Paul Gortmaker<paul.gortmaker@windriver•com> wrote:
>>
>> On Mon, Feb 20, 2012 at 6:20 PM, tip-bot for David Howells
>> <dhowells@redhat•com> wrote:
>>> Commit-ID: d66acc39c7cee323733c8503b9de1821a56dff7e
>>> Gitweb: http://git.kernel.org/tip/d66acc39c7cee323733c8503b9de1821a56dff7e
>>> Author: David Howells<dhowells@redhat•com>
>>> AuthorDate: Mon, 20 Feb 2012 22:39:29 +0000
>>> Committer: H. Peter Anvin<hpa@zytor•com>
>>> CommitDate: Mon, 20 Feb 2012 14:47:02 -0800
>>>
>>> bitops: Optimise get_order()
>>
>> This is causing build failures on non-x86 in linux next according to git bisect.
>
> Presumably it needs to include linux/bitops.h (and see below).
>
>>> +static inline __attribute_const__
>>> +int __get_order(unsigned long size)
>>> +{
>>> + int order;
>>> +
>>> + size--;
>>> + size>>= PAGE_SHIFT;
>>> +#if BITS_PER_LONG == 32
>>> + order = fls(size);
>>> +#else
>>> + order = fls64(size);
>>> +#endif
>
> linux/bitops.h has fls_long() that does this size test and calls the right thing.
>
next prev parent reply other threads:[~2012-03-01 21:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120220223928.16199.29548.stgit@warthog.procyon.org.uk>
[not found] ` <tip-d66acc39c7cee323733c8503b9de1821a56dff7e@git.kernel.org>
2012-02-29 20:29 ` [tip:x86/asm] bitops: Optimise get_order() Paul Gortmaker
2012-03-01 0:31 ` Stephen Rothwell
2012-03-01 21:02 ` H. Peter Anvin [this message]
2012-03-06 14:24 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FE3F7.5030508@zytor.com \
--to=hpa@zytor$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-tip-commits@vger$(echo .)kernel.org \
--cc=mingo@redhat$(echo .)com \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox