From: Peter Ujfalusi <peter.ujfalusi@ti•com>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: tony@atomide•com, linux-omap@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-next@vger•kernel.org,
Mark Brown <broonie@opensource•wolfsonicro.com>,
Samuel Ortiz <sameo@linux•intel.com>
Subject: Re: [PATCH 3/3] arm: more fallout from i2c conversions in board-omap4panda.c
Date: Tue, 06 Mar 2012 14:27:24 +0200 [thread overview]
Message-ID: <4F5602AC.3060107@ti.com> (raw)
In-Reply-To: <1330987310-8108-4-git-send-email-paul.gortmaker@windriver.com>
Hi,
On 03/06/2012 12:41 AM, Paul Gortmaker wrote:
> Commit ded0df8510778a03a2f182a0cbfe3c25788e8852 (linux-next)
>
> "mfd: Convert twl6040 to an i2c driver, and separate it from twl core"
>
> appears to have done an incomplete conversion on the board-omap4panda.c
> file, leaving it with more build failures. Comparing the changes that
> were done for board-4430sdp.c it is possible for me to whack it with a
> stick until it stops twitching, but someone who really understands this
> code needs to take a look at the conversion, and check it is done
> completely and in a way that will actually work on hardware.
This is true.
I'm sending a revert series for the twl6040 patches causing this
breakage for Samuel.
The same feature will go via audio tree because the dependencies are
queued in that feature tree.
--
Péter
PS: this might fix the compile breakage with omap2_defconfig, but the
audio will not work if you enable the support for it on OMAP4.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
> CC: Peter Ujfalusi <peter.ujfalusi@ti•com>
> CC: Mark Brown <broonie@opensource•wolfsonicro.com>
> CC: Samuel Ortiz <sameo@linux•intel.com>
> ---
> arch/arm/mach-omap2/board-omap4panda.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> index e919153..16a1814 100644
> --- a/arch/arm/mach-omap2/board-omap4panda.c
> +++ b/arch/arm/mach-omap2/board-omap4panda.c
> @@ -287,16 +287,15 @@ static struct twl6040_codec_data twl6040_codec = {
> .hf_right_step = 0x1d,
> };
>
> -static struct twl4030_audio_data twl6040_audio = {
> +static struct twl6040_platform_data twl6040_data = {
> .codec = &twl6040_codec,
> .audpwron_gpio = 127,
> - .naudint_irq = OMAP44XX_IRQ_SYS_2N,
> .irq_base = TWL6040_CODEC_IRQ_BASE,
> };
>
> /* Panda board uses the common PMIC configuration */
> static struct twl4030_platform_data omap4_panda_twldata = {
> - .audio = &twl6040_audio,
> + /* .audio = &twl6040_audio, */
> };
>
> /*
prev parent reply other threads:[~2012-03-06 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 22:41 [PATCH 0/3] arm: fix build breakage in omap2plus_defconfig (linux-next) Paul Gortmaker
2012-03-05 22:41 ` [PATCH 1/3] arm: anticipate build breakages due in pending merge Paul Gortmaker
2012-03-05 22:45 ` Tony Lindgren
2012-03-05 22:41 ` [PATCH 2/3] arm: fix compile error in mach-omap2/board-omap4panda.c Paul Gortmaker
2012-03-05 22:46 ` Tony Lindgren
2012-03-06 11:03 ` Peter Ujfalusi
2012-03-05 22:41 ` [PATCH 3/3] arm: more fallout from i2c conversions in board-omap4panda.c Paul Gortmaker
2012-03-06 12:27 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5602AC.3060107@ti.com \
--to=peter.ujfalusi@ti$(echo .)com \
--cc=broonie@opensource$(echo .)wolfsonicro.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=sameo@linux$(echo .)intel.com \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox