From: Antti Palosaari <crope@iki•fi>
To: gennarone@gmail•com
Cc: Geert Uytterhoeven <geert@linux-m68k•org>,
linux-media@vger•kernel.org,
Mauro Carvalho Chehab <mchehab@redhat•com>,
Linux-Next <linux-next@vger•kernel.org>
Subject: Re: rtl2830: __udivdi3 undefined
Date: Mon, 12 Mar 2012 21:58:53 +0200 [thread overview]
Message-ID: <4F5E557D.5000403@iki.fi> (raw)
In-Reply-To: <4F53EA7D.4090402@gmail.com>
On 05.03.2012 00:19, Gianluca Gennari wrote:
> Il 29/02/2012 22:30, Geert Uytterhoeven ha scritto:
>> http://kisskb.ellerman.id.au/kisskb/buildresult/5759200/ ERROR:
>> "__udivdi3" [drivers/media/dvb/frontends/rtl2830.ko] undefined!
>>
>> I didn't look too deeply into it, but I think it's caused by the
>> "num /= priv->cfg.xtal" in rtl2830_init() (with num being u64).
>>
>> Can't it use do_div() instead?
>>
>> Gr{oetje,eeting}s,
>>
>> Geert
>>
>> -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
>> geert@linux-m68k•org
>>
>> In personal conversations with technical people, I call myself a
>> hacker. But when I'm talking to journalists I just say "programmer"
>> or something like that. -- Linus Torvalds -- To unsubscribe from this
>> list: send the line "unsubscribe linux-media" in the body of a
>> message to majordomo@vger•kernel.org More majordomo info at
>> http://vger.kernel.org/majordomo-info.html
>>
>
> Probably the best solution is to use div_u64.
> The following patch fixed the warning on my 32 bit system.
>
> Signed-off-by: Gianluca Gennari<gennarone@gmail•com>
> ---
> drivers/media/dvb/frontends/rtl2830.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/rtl2830.c
> b/drivers/media/dvb/frontends/rtl2830.c
> index f971d94..45196c5 100644
> --- a/drivers/media/dvb/frontends/rtl2830.c
> +++ b/drivers/media/dvb/frontends/rtl2830.c
> @@ -244,7 +244,7 @@ static int rtl2830_init(struct dvb_frontend *fe)
>
> num = priv->cfg.if_dvbt % priv->cfg.xtal;
> num *= 0x400000;
> - num /= priv->cfg.xtal;
> + num = div_u64(num, priv->cfg.xtal);
> num = -num;
> if_ctl = num& 0x3fffff;
> dbg("%s: if_ctl=%08x", __func__, if_ctl);
Acked-by: Antti Palosaari <crope@iki•fi>
I have been two weeks on skiing trip and since didn't acked that earlier.
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2012-03-12 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 21:30 rtl2830: __udivdi3 undefined Geert Uytterhoeven
2012-03-04 22:19 ` Gianluca Gennari
2012-03-06 18:02 ` Geert Uytterhoeven
2012-03-12 19:58 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E557D.5000403@iki.fi \
--to=crope@iki$(echo .)fi \
--cc=geert@linux-m68k$(echo .)org \
--cc=gennarone@gmail$(echo .)com \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mchehab@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox