Subject: Re: [PATCH] x86: export 'pcibios_enabled'

From: "H. Peter Anvin" <[email-masked]>
Date: Tue, 13 Mar 2012 17:43:25 -0700

On 03/13/2012 01:30 PM, Randy Dunlap wrote:
> From: Randy Dunlap <[email-masked]>
> 
> Export 'pcibios_enabled' so that when uvesafb is built as a
> loadable module (on X86_32), the build will succeed.
> 
> ERROR: "pcibios_enabled" [drivers/video/uvesafb.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <[email-masked]>
> Cc:	Michal Januszewski <[email-masked]>
> Cc:	Florian Tobias Schandinat <[email-masked]>
> Cc:	[email-masked]
> Cc:	[email-masked]
> ---
> Applies to mainline; found in linux-next.
> 
>  arch/x86/pci/pcbios.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20120313.orig/arch/x86/pci/pcbios.c
> +++ linux-next-20120313/arch/x86/pci/pcbios.c
> @@ -27,6 +27,7 @@
>  #define PCIBIOS_HW_TYPE2_SPEC		0x20
>  
>  int pcibios_enabled;
> +EXPORT_SYMBOL(pcibios_enabled);
>  
>  /* According to the BIOS specification at:
>   * http://members.datafast.net.au/dft0802/specs/bios21.pdf, we could

I would think this should be EXPORT_SYMBOL_GPL()... this seems like a
symbol with a very high likelihood to be abused in strange ways.

	-hpa