From: Paul Gortmaker <paul.gortmaker@windriver•com>
To: Mark Brown <broonie@opensource•wolfsonmicro.com>
Cc: Igor Grinberg <grinberg@compulab•co.il>,
haojian.zhuang@gmail•com, linux-arm-kernel@lists•infradead.org,
linux-next@vger•kernel.org
Subject: Re: [PATCH] ARM: pxa: fix build failure for regulator consumer in em-x270.c
Date: Thu, 29 Mar 2012 10:57:08 -0400 [thread overview]
Message-ID: <4F747844.9000900@windriver.com> (raw)
In-Reply-To: <20120329145436.GS3668@opensource.wolfsonmicro.com>
On 12-03-29 10:54 AM, Mark Brown wrote:
> On Thu, Mar 29, 2012 at 04:28:48PM +0200, Igor Grinberg wrote:
>> On 03/28/12 18:59, Paul Gortmaker wrote:
>
>>>>> static struct platform_device em_x270_gps_userspace_consumer = {
>>>>> .name = "reg-userspace-consumer",
>>>>> .id = 0,
>
>>>>> static struct platform_device em_x270_gprs_userspace_consumer = {
>>>>> .name = "reg-userspace-consumer",
>>>>> .id = 1,
>
>>> -REGULATOR_CONSUMER(ldo19, "reg-userspace-consumer", "vcc gprs");
>>> +REGULATOR_CONSUMER(ldo19, "reg-userspace-consumer.1", "vcc gprs");
>
>> Well, I thought of this solution, but I don't like it, as it makes
>> the whole thing very fragile and sensitive to the reg-userspace-consumer
>> platform device registration order and count, isn't it?
>> (That's why I proposed to use NULL...).
>
> No the platform device numbering should be totally stable for a given
> board unless someone deliberately sets out to renumber them - the .ids
> are explicitly assigned by the board when it registers the device.
>
>> So, Mark, how do you think the above issues can be handled without
>> putting NULL into the dev_name?
>
> It shouldn't be a problem I think.
Mark,
Would you like me to send a v3 with the .0 and .1 added, or
are you OK with making that small change to v2 yourself?
Paul.
next prev parent reply other threads:[~2012-03-29 14:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 23:12 [PATCH] ARM: pxa: fix build failure for regulator consumer in em-x270.c Paul Gortmaker
2012-03-06 8:46 ` Igor Grinberg
2012-03-06 9:12 ` Haojian Zhuang
2012-03-06 12:16 ` Mark Brown
2012-03-06 12:22 ` Haojian Zhuang
2012-03-07 0:10 ` Paul Gortmaker
2012-03-08 22:06 ` Paul Gortmaker
2012-03-28 15:21 ` Igor Grinberg
2012-03-28 15:27 ` Mark Brown
2012-03-28 15:37 ` Haojian Zhuang
2012-03-28 15:39 ` Mark Brown
2012-03-28 15:59 ` Paul Gortmaker
2012-03-28 16:13 ` Mark Brown
2012-03-28 16:59 ` Paul Gortmaker
2012-03-29 14:28 ` Igor Grinberg
2012-03-29 14:54 ` Mark Brown
2012-03-29 14:57 ` Paul Gortmaker [this message]
2012-03-29 15:11 ` Mark Brown
2012-03-29 14:55 ` Paul Gortmaker
2012-03-30 11:25 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F747844.9000900@windriver.com \
--to=paul.gortmaker@windriver$(echo .)com \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=grinberg@compulab$(echo .)co.il \
--cc=haojian.zhuang@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox