Subject: Re: [PATCH -next] tty: add missing tty_port_tty_get() call to raw3215_wakeup

From: Jiri Slaby <[email-masked]>
Date: Tue, 17 Apr 2012 14:35:32 +0200

On 04/17/2012 01:16 PM, Heiko Carstens wrote:
> Fix compile error caused by "TTY: con3215, use tty from tty_port":
> 
>  CC      drivers/s390/char/con3215.o
> drivers/s390/char/con3215.c: In function 'raw3215_wakeup':
> drivers/s390/char/con3215.c:339:16: error: 'struct raw3215_info' has no member named 'tty'
> make[1]: *** [drivers/s390/char/con3215.o] Error 1
> make: *** [drivers/s390/char/] Error 2

Aha, that's because I rebased the tasklet removal patch on the top of
the other two patches so I don't see the error in my local tree.

> Cc: Jiri Slaby <[email-masked]>

Acked-by: Jiri Slaby <[email-masked]>

and thanks.

> Cc: Martin Schwidefsky <[email-masked]>
> Signed-off-by: Heiko Carstens <[email-masked]>
> ---
>  drivers/s390/char/con3215.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index e928e04..6c0116d 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -336,7 +336,11 @@ static inline void raw3215_try_io(struct raw3215_info *raw)
>  static void raw3215_wakeup(unsigned long data)
>  {
>  	struct raw3215_info *raw = (struct raw3215_info *) data;
> -	tty_wakeup(raw->tty);
> +	struct tty_struct *tty;
> +
> +	tty = tty_port_tty_get(&raw->port);
> +	tty_wakeup(tty);
> +	tty_kref_put(tty);
>  }
>  
>  /*
> 
-- 
js
suse labs