From: Randy Dunlap <rdunlap@xenotime•net>
To: Alan Stern <stern@rowland•harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Ian Abbott <abbotti@mev•co.uk>,
Frank Mori Hess <fmhess@users•sourceforge.net>,
devel@driverdev•osuosl.org, USB list <linux-usb@vger•kernel.org>
Subject: Re: [PATCH -next] usb: add usb.h stubs for CONFIG_USB not enabled
Date: Sat, 19 May 2012 08:48:52 -0700 [thread overview]
Message-ID: <4FB7C0E4.4000008@xenotime.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1205191026400.1348-100000@netrider.rowland.org>
On 05/19/2012 07:30 AM, Alan Stern wrote:
> On Fri, 18 May 2012, Randy Dunlap wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime•net>
>>
>> Add stubs for some usb core functions when CONFIG_USB
>> is not enabled. This fixes these comedi build errors:
>>
>> ERROR: "usb_deregister" [drivers/staging/comedi/comedi.ko] undefined!
>> ERROR: "usb_register_driver" [drivers/staging/comedi/comedi.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime•net>
>> ---
>> I am only adding the stubs that are needed for comedi to build.
>> I expect that more stubs will be needed as more build errors are
>> found. It seems to me that linux/usb.h might need more (major)
>> moving of lines to support more stubs in the future.
>
> This doesn't seem like the right thing to do. If a driver needs to
> register with the USB core then that driver should depend on
> CONFIG_USB.
>
> On the other hand, if the driver is capable of being built without USB
> support then it should use the necessary preprocessor tests to protect
> calls to any USB routines.
Yeah, my first patch (not on linux-usb list) to staging/comedi/drivers.c
just surrounded the usb helper functions with IS_ENABLED(CONFIG_USB).
I'm fine with that patch, but Greg said that he wanted stubs...
--
~Randy
next prev parent reply other threads:[~2012-05-19 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 8:49 linux-next: Tree for May 18 Stephen Rothwell
2012-05-19 0:46 ` [PATCH -next] comedi: fix build when USB is not enabled Randy Dunlap
2012-05-19 0:50 ` Greg Kroah-Hartman
2012-05-19 0:51 ` Randy Dunlap
2012-05-19 2:04 ` [PATCH -next] usb: add usb.h stubs for CONFIG_USB " Randy Dunlap
[not found] ` <4FB6FFBF.6000509-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-05-19 14:16 ` Sergei Shtylyov
2012-05-19 15:45 ` Randy Dunlap
2012-05-19 16:12 ` Greg Kroah-Hartman
2012-05-19 16:31 ` [PATCH -next v2] " Randy Dunlap
2012-05-21 16:48 ` H Hartley Sweeten
2012-05-19 14:30 ` [PATCH -next] " Alan Stern
2012-05-19 15:48 ` Randy Dunlap [this message]
[not found] ` <4FB7C0E4.4000008-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org>
2012-06-11 23:07 ` Greg Kroah-Hartman
2012-06-11 23:35 ` [PATCH] staging/comedi: fix build for USB " Randy Dunlap
2012-05-19 1:02 ` linux-next: Tree for May 18 (drm drivers and vgacon) Randy Dunlap
2012-05-19 15:40 ` Dave Airlie
2012-05-19 2:16 ` linux-next: Tree for May 18 (edac) Randy Dunlap
2012-05-19 12:03 ` Mauro Carvalho Chehab
2012-05-19 15:50 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB7C0E4.4000008@xenotime.net \
--to=rdunlap@xenotime$(echo .)net \
--cc=abbotti@mev$(echo .)co.uk \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=fmhess@users$(echo .)sourceforge.net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=stern@rowland$(echo .)harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox