Subject: [PATCH] Fix section mismatch: ata_sff_exit

From: "Luck, Tony" <[email-masked]>
Date: Mon, 23 Aug 2010 13:18:02 -0700

This build error showed up in linux-next tag next-20100820 for ia64:

WARNING: vmlinux.o(.init.text+0x4a952): Section mismatch in reference from the function ata_init() to the function .exit.text:ata_sff_exit()
The function __init ata_init() references
a function __exit ata_sff_exit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __exit annotation of
ata_sff_exit() so it may be used outside an exit section.

Sure enough, dropping the __exit fixes the problem.

Signed-off-by: Tony Luck <[email-masked]>

---

Tejun: I didn't pin down which commit broke this ... but you seem
to have a number of recent commits here.

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 57ea9c7..36b8855 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -3326,7 +3326,7 @@ int __init ata_sff_init(void)
 	return 0;
 }
 
-void __exit ata_sff_exit(void)
+void ata_sff_exit(void)
 {
 	destroy_workqueue(ata_sff_wq);
 }