From: "Michal Vokáč" <michal.vokac@ysoft•com>
To: Stephen Rothwell <sfr@canb•auug.org.au>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>
Cc: Linux Next Mailing List <linux-next@vger•kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the fbdev tree
Date: Mon, 11 Feb 2019 10:10:33 +0100 [thread overview]
Message-ID: <4cf3fb95-e7d6-8813-c6f6-2075ca50e18c@ysoft.com> (raw)
In-Reply-To: <20190211072443.1cbedb29@canb.auug.org.au>
On 10. 02. 19 21:24, Stephen Rothwell wrote:
> Hi Bartlomiej,
>
> In commit
>
> 7d7e58d30e04 ("dt-bindings: display: ssd1307fb: Remove reset-active-low from examples")
>
> Fixes tag
>
> Fixes: 519b4db ("fbdev: ssd1307fb: Remove reset-active-low from the DT binding document")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
Hi Stephen,
Sorry, that is my fault, I put the Fixes tag into the submitted patch.
Thanks for the git configuration hint. All my machines were configured
correctly except the one I generated the Fixes tag on, ups :(
Normally checkpatch.pl does a good job identifying errors in referenced
commits. Unfortunately it did not complain in this case. Would be nice
to add this check. I skimmed through the appropriate part of the script
but I do not feel like adding this feature myself, Perl is not my domain.
Sorry for the inconvenience.
Michal
next prev parent reply other threads:[~2019-02-11 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 20:24 linux-next: Fixes tag needs some work in the fbdev tree Stephen Rothwell
2019-02-11 9:10 ` Michal Vokáč [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-17 21:33 Stephen Rothwell
2022-01-17 21:41 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cf3fb95-e7d6-8813-c6f6-2075ca50e18c@ysoft.com \
--to=michal.vokac@ysoft$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox