Subject: Re: linux-next: build failure after merge of the pmdomain tree

From: Shawn Lin <[email-masked]>
Date: Thu, 20 Feb 2025 09:53:44 +0800

在 2025/2/20 8:33, Stephen Rothwell 写道:
> Hi all,
> 
> After merging the pmdomain tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> x86_64-linux-gnu-ld: vmlinux.o: in function `rockchip_do_pmu_set_power_domain':
> pm-domains.c:(.text+0x19aa103): undefined reference to `arm_smccc_1_1_get_conduit'
> 
> Caused by commit
> 
>    61eeb9678789 ("pmdomain: rockchip: Check if SMC could be handled by TA")
> 
> $ grep CONFIG_HAVE_ARM_SMCCC_DISCOVERY .config

It seems x86_64_defconfig did't enable  CONFIG_HAVE_ARM_SMCCC_DISCOVERY 
which apparently belongs to ARM stuff.

Selecting HAVE_ARM_SMCCC_DISCOVERY and ARM_PSCI_FW should pass the
x86_64 allmodconfig compile.

--- a/drivers/pmdomain/rockchip/Kconfig
+++ b/drivers/pmdomain/rockchip/Kconfig
@@ -5,6 +5,8 @@ config ROCKCHIP_PM_DOMAINS
         bool "Rockchip generic power domain"
         depends on PM
         select PM_GENERIC_DOMAINS
+       select ARM_PSCI_FW
+       select HAVE_ARM_SMCCC_DISCOVERY
         help
           Say y here to enable power domain support.
           In order to meet high performance and low power requirements, 
a power

> $
> 
> I have used the pmdomain tree from next-20250219 for today.
>