From: Damian Hobson-Garcia <dhobsong@igel•co.jp>
To: Geert Uytterhoeven <geert@linux-m68k•org>
Cc: hjk@hansjkoch•de, gregkh@linuxfoundation•org,
magnus.damm@gmail•com, horms@verge•net.au,
linux-kernel@vger•kernel.org, linux-sh@vger•kernel.org,
hdk@igel•co.jp, Linux-Next <linux-next@vger•kernel.org>,
Linux-Arch <linux-arch@vger•kernel.org>
Subject: Re: [v2 PATCH 1/2] Add new uio device for dynamic memory allocation
Date: Mon, 05 Nov 2012 11:34:50 +0900 [thread overview]
Message-ID: <509725CA.4030809@igel.co.jp> (raw)
In-Reply-To: <CAMuHMdWKByLXR-2wkiej=F1WPf7xePf3nMkUqwSf_hEJNNZbvg@mail.gmail.com>
Hi Geert,
On 2012/11/04 22:20, Geert Uytterhoeven wrote:
> On Tue, Sep 25, 2012 at 8:09 AM, Damian Hobson-Garcia
> <dhobsong@igel•co.jp> wrote:
>> are holding the device file open, the address returned to userspace is
>> DMA_ERROR_CODE.
>
> Only a small subset of the architectures
> (arm/ia64/microblaze/openrisc/powerpc/sparc/x86)
> seem to define DMA_ERROR_CODE, causing everywhere else:
>
> drivers/uio/uio_dmem_genirq.c: In function ‘uio_dmem_genirq_release’:
> drivers/uio/uio_dmem_genirq.c:95: error: ‘DMA_ERROR_CODE’ undeclared
> (first use in this function)
> drivers/uio/uio_dmem_genirq.c:95: error: (Each undeclared identifier
> is reported only once
> drivers/uio/uio_dmem_genirq.c:95: error: for each function it appears in.)
> drivers/uio/uio_dmem_genirq.c: In function ‘uio_dmem_genirq_probe’:
> drivers/uio/uio_dmem_genirq.c:238: error: ‘DMA_ERROR_CODE’ undeclared
> (first use in this function)
> make[1]: *** [drivers/uio/uio_dmem_genirq.o] Error 1
> make: *** [drivers/uio/] Error 2
>
> (e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/7462173/)
>
> Furthermore, none of them define it in <uapi/...>, so DMA_ERROR_CODE is not
> part of the userspace API (yet), while it is architecture-specific (some use 0,
> others ~0).
>
Good points, thank you. In that case, does fixing the value to
something like ~0 sound like a better (more portable) solution?
Damian
--
Damian Hobson-Garcia
IGEL Co.,Ltd
http://www.igel.co.jp
prev parent reply other threads:[~2012-11-05 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348553352-14334-1-git-send-email-dhobsong@igel.co.jp>
[not found] ` <1348553352-14334-2-git-send-email-dhobsong@igel.co.jp>
2012-11-04 13:20 ` [v2 PATCH 1/2] Add new uio device for dynamic memory allocation Geert Uytterhoeven
2012-11-05 2:34 ` Damian Hobson-Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509725CA.4030809@igel.co.jp \
--to=dhobsong@igel$(echo .)co.jp \
--cc=geert@linux-m68k$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hdk@igel$(echo .)co.jp \
--cc=hjk@hansjkoch$(echo .)de \
--cc=horms@verge$(echo .)net.au \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=magnus.damm@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox