Subject: Re: [PATCH -next] mfd: fix stmpe.c build when OF is not enabled

From: Randy Dunlap <[email-masked]>
Date: Mon, 26 Nov 2012 11:21:33 -0800

On 11/13/2012 05:35 AM, Linus Walleij wrote:

> On Mon, Nov 12, 2012 at 6:20 PM, Randy Dunlap <[email-masked]> wrote:
> 
>> From: Randy Dunlap <[email-masked]>
>>
>> Fix build errors when CONFIG_OF is not enabled by including
>> <linux/of.h> (needs to be added in any case).
>> An alternative fix could be to make the driver depend on OF.
>>
>> drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
>> drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
>> drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token
>>
>> Signed-off-by: Randy Dunlap <[email-masked]>
>> Cc: Rabin Vincent <[email-masked]>
>> Cc: Samuel Ortiz <[email-masked]>
> 
> Acked-by: Linus Walleij <[email-masked]>

ping?

This patch is still needed in linux-next.

---
From: Randy Dunlap <[email-masked]>

Fix build errors when CONFIG_OF is not enabled by including
<linux/of.h> (needs to be added in any case).
An alternative fix could be to make the driver depend on OF.

drivers/mfd/stmpe.c:1025:2: error: implicit declaration of function 'of_property_read_u32'
drivers/mfd/stmpe.c:1030:2: error: implicit declaration of function 'for_each_child_of_node'
drivers/mfd/stmpe.c:1030:36: error: expected ';' before '{' token

Signed-off-by: Randy Dunlap <[email-masked]>
Cc: Rabin Vincent <[email-masked]>
Cc: Samuel Ortiz <[email-masked]>
Acked-by: Linus Walleij <[email-masked]>
---
 drivers/mfd/stmpe.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20121112.orig/drivers/mfd/stmpe.c
+++ linux-next-20121112/drivers/mfd/stmpe.c
@@ -13,6 +13,7 @@
 #include <linux/interrupt.h>
 #include <linux/irq.h>
 #include <linux/irqdomain.h>
+#include <linux/of.h>
 #include <linux/pm.h>
 #include <linux/slab.h>
 #include <linux/mfd/core.h>