Subject: Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG

From: Randy Dunlap <[email-masked]>
Date: Tue, 27 Nov 2012 10:42:13 -0800

On 11/26/2012 11:11 PM, Peter Hurley wrote:

> Use WARN() as intended.
> 
> Signed-off-by: Peter Hurley <[email-masked]>

Reported-by: Randy Dunlap <[email-masked]>
Acked-by: Randy Dunlap <[email-masked]>

Thanks.

> ---
>  drivers/staging/fwserial/dma_fifo.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
> index 72aa053..5e84634 100644
> --- a/drivers/staging/fwserial/dma_fifo.c
> +++ b/drivers/staging/fwserial/dma_fifo.c
> @@ -33,10 +33,7 @@
>  
>  #define FAIL(fifo, condition, format...) ({				\
>  	fifo->corrupt = !!(condition);					\
> -	if (unlikely(fifo->corrupt)) {					\
> -		__WARN_printf(format);					\
> -	}								\
> -	unlikely(fifo->corrupt);					\
> +	WARN(fifo->corrupt, format);					\
>  })
>  
>  /*

-- 
~Randy