Subject: Re: [PATCH] extcon: max77693: Fix bug of build error related to INPUT subsystem

From: Randy Dunlap <[email-masked]>
Date: Fri, 25 Jan 2013 08:59:06 -0800

On 01/24/13 17:56, Chanwoo Choi wrote:
> This patch fix build error of following log:
> 
> drivers/built-in.o: In function `max77693_muic_remove':
> extcon-max77693.c:(.text+0x664853): undefined reference to `input_unregister_device'
> drivers/built-in.o: In function `max77693_muic_probe':
> extcon-max77693.c:(.text+0x664971): undefined reference to `input_allocate_device'
> extcon-max77693.c:(.text+0x6649c1): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x6649d6): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x6649eb): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x664a00): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x664a15): undefined reference to `input_set_capability'
> extcon-max77693.c:(.text+0x664a20): undefined reference to `input_register_device'
> drivers/built-in.o: In function `max77693_muic_adc_handler':
> extcon-max77693.c:(.text+0x665318): undefined reference to `input_event'
> extcon-max77693.c:(.text+0x66532a): undefined reference to `input_event'
> make[1]: *** [vmlinux] Error 1
> 
> Signed-off-by: Chanwoo Choi <[email-masked]>
> Signed-off-by: Myungjoo Ham <[email-masked]>

Reported-by: Randy Dunlap <[email-masked]>
Acked-by: Randy Dunlap <[email-masked]>

Thanks.

> ---
>  drivers/extcon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 07122a9..10df3fa 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -29,7 +29,7 @@ config EXTCON_ADC_JACK
>  
>  config EXTCON_MAX77693
>  	tristate "MAX77693 EXTCON Support"
> -	depends on MFD_MAX77693
> +	depends on MFD_MAX77693 && INPUT
>  	select IRQ_DOMAIN
>  	select REGMAP_I2C
>  	help
> 

-- 
~Randy