From: Randy Dunlap <rdunlap@infradead•org>
To: David Rientjes <rientjes@google•com>
Cc: HATAYAMA Daisuke <d.hatayama@jp•fujitsu.com>,
Stephen Rothwell <sfr@canb•auug.org.au>,
Andrew Morton <akpm@linux-foundation•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
kexec@lists•infradead.org
Subject: Re: linux-next: Tree for Mar 20 (vmcore)
Date: Wed, 20 Mar 2013 11:58:00 -0700 [thread overview]
Message-ID: <514A06B8.9060808@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1303201153330.17761@chino.kir.corp.google.com>
On 03/20/13 11:56, David Rientjes wrote:
> On Wed, 20 Mar 2013, Randy Dunlap wrote:
>
>> on x86_64:
>>
>> fs/proc/vmcore.c: In function 'merge_note_headers_elf64':
>> fs/proc/vmcore.c:349:22: error: 'VMCOREINFO_NOTE_NAME' undeclared (first use in this function)
>> fs/proc/vmcore.c:349:22: note: each undeclared identifier is reported only once for each function it appears in
>> fs/proc/vmcore.c: In function 'merge_note_headers_elf32':
>> fs/proc/vmcore.c:470:22: error: 'VMCOREINFO_NOTE_NAME' undeclared (first use in this function)
>> make[3]: *** [fs/proc/vmcore.o] Error 1
>>
>>
>> Needs to #include <linux/kexec.h>
>>
>
> I don't think that's it, linux/kexec.h already gets included indirectly.
> The problem is that CONFIG_KEXEC isn't set so the definition in kexec.h is
> meaningless.
Thanks. I meant to check on CONFIG_KEXEC and then forgot to do that.
> This comes from "vmcore: check NT_VMCORE_PAD as a mark indicating the end
> of ELF note buffer" merged through the -mm tree. I've added the patch's
> author and Andrew to the cc.
>
> How can this be protected by CONFIG_KEXEC?
> --
--
~Randy
next prev parent reply other threads:[~2013-03-20 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 5:05 linux-next: Tree for Mar 20 Stephen Rothwell
2013-03-20 16:47 ` linux-next: Tree for Mar 20 (vmcore) Randy Dunlap
2013-03-20 18:56 ` David Rientjes
2013-03-20 18:58 ` Randy Dunlap [this message]
2013-03-21 0:10 ` David Rientjes
2013-03-21 2:20 ` Stephen Rothwell
2013-03-21 2:49 ` David Rientjes
2013-03-21 3:51 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514A06B8.9060808@infradead.org \
--to=rdunlap@infradead$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=d.hatayama@jp$(echo .)fujitsu.com \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rientjes@google$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox