From: "Arend van Spriel" <arend-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public•gmane.org>
Cc: "John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>,
Hante Meuleman <meuleman-dY08KVG/lbpWk0Htik3J/w@public•gmane.org>,
"'linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org'"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
"linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org"
<linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: Regression in 9390ace brcmfmac: free net device when registration fails
Date: Tue, 4 Jun 2013 14:58:37 +0200 [thread overview]
Message-ID: <51ADE47D.50700@broadcom.com> (raw)
In-Reply-To: <51AD1F22.2080004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 06/04/2013 12:56 AM, Stephen Warren wrote:
> (John, note that this commit is part of the pull request you sent to
> Dave today)
>
> Arend,
>
> Commit 9390ace "brcmfmac: free net device when registration fails"
> causes a regression.
>
> I had the BCM4330 firmware present in my root fs, whereas my HW is a
> BCM4329. With this patch applied, I get a kernel panic on boot. With it
> reverted, I see that no issues of that nature. This is true in
> next-20130531 (and also 5/30 and 6/1 but not earlier). A bisect of
> Linus's tree followed by a merge of John's wireless pull request from
> today pointed at this same commit.
Thanks, Stephen
I will look into this.
> Related: Since the two hardware require different firmware, I wonder why
> the driver doesn't use a firmware filename that encodes the HW device ID
> instead of using the same name for all HW. This means that when I move
> my SD card between development systems, I have to copy different
> firmware over the top. That's a little painful...
I agree that for development switching cards it is kinda awkward and I
have been fooled by it as well. We may want to change or if your itch is
annoying enough feel free to send a patch for it ;-)
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-04 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 22:56 Regression in 9390ace brcmfmac: free net device when registration fails Stephen Warren
[not found] ` <51AD1F22.2080004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-04 12:58 ` Arend van Spriel [this message]
2013-06-06 21:10 ` Arend van Spriel
2013-06-06 21:36 ` Stephen Warren
2013-06-12 21:19 ` Stephen Warren
2013-06-13 8:09 ` Arend van Spriel
2013-06-13 17:32 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADE47D.50700@broadcom.com \
--to=arend-dy08kvg/lbpwk0htik3j/w@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=meuleman-dY08KVG/lbpWk0Htik3J/w@public$(echo .)gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox