From: Stephen Warren <swarren@wwwdotorg•org>
To: David Herrmann <dh.herrmann@gmail•com>
Cc: "dri-devel@lists•freedesktop.org"
<dri-devel@lists•freedesktop.org>,
"linux-next@vger•kernel.org" <linux-next@vger•kernel.org>,
Dave Airlie <airlied@redhat•com>
Subject: Build break due to 28ec711 "drm/agp: move AGP cleanup paths to drm_agpsupport.c"
Date: Thu, 08 Aug 2013 12:00:16 -0600 [thread overview]
Message-ID: <5203DCB0.9060409@wwwdotorg.org> (raw)
In next-20130808, building tegra_defconfig for ARM yields:
> drivers/built-in.o: In function `drm_lastclose':
> /home/swarren/shared/git_wa/kernel/kernel.git/drivers/gpu/drm/drm_drv.c:198: undefined reference to `drm_agp_clear'
That's because drm_agp_clear() is called unconditionally, yet is only
conditionally built into drm_agpsupport.c (#if __OS_HAS_AGP).
Should the call from drm_drv.c be conditional, or should there be a
dummy static inline replacement in include/drm/drmP.h for when AGP
support isn't available?
next reply other threads:[~2013-08-08 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 18:00 Stephen Warren [this message]
2013-08-08 18:13 ` Build break due to 28ec711 "drm/agp: move AGP cleanup paths to drm_agpsupport.c" David Herrmann
2013-08-08 19:21 ` Stephen Warren
2013-08-08 20:00 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203DCB0.9060409@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=airlied@redhat$(echo .)com \
--cc=dh.herrmann@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox