From: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public•gmane.org>
To: Sebastian Andrzej Siewior
<sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public•gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public•gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public•gmane.org>,
Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public•gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
Subject: Re: [PATCH] usb: phy: am335x-control: make it compile with
Date: Fri, 16 Aug 2013 11:00:09 -0700 [thread overview]
Message-ID: <520E68A9.1020406@infradead.org> (raw)
In-Reply-To: <20130816153249.GA3570-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
On 08/16/13 08:32, Sebastian Andrzej Siewior wrote:
> From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
>
> Randy reported this
> |drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration
> |of function '__WARN' [-Werror=implicit-function-declaration]
>
> and left it as an excercice to figure out that this happens only with
> CONFIG_BUG=n. As a fix I replace it with WARN_ON(). And there is a space
> before return so fix this, too.
>
> Reported-by: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public•gmane.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public•gmane.org>
Acked-by: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public•gmane.org>
Thanks.
> ---
> drivers/usb/phy/phy-am335x-control.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c
> index 7597545..22cf07d 100644
> --- a/drivers/usb/phy/phy-am335x-control.c
> +++ b/drivers/usb/phy/phy-am335x-control.c
> @@ -42,8 +42,8 @@ static void am335x_phy_power(struct phy_control *phy_ctrl, u32 id, bool on)
> reg = AM335X_USB1_CTRL;
> break;
> default:
> - __WARN();
> - return;
> + WARN_ON(1);
> + return;
> }
>
> val = readl(usb_ctrl->phy_reg + reg);
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-16 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 6:58 linux-next: Tree for Aug 15 Stephen Rothwell
2013-08-15 17:07 ` linux-next: Tree for Aug 15 (usb/phy/phy-am335x-control.c) Randy Dunlap
2013-08-16 10:46 ` Roger Quadros
2013-08-16 15:32 ` [PATCH] usb: phy: am335x-control: make it compile with Sebastian Andrzej Siewior
[not found] ` <20130816153249.GA3570-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2013-08-16 18:00 ` Randy Dunlap [this message]
2013-08-16 15:40 ` [PATCH] dma: cpp41: make it compile with CONFIG_BUG=n Sebastian Andrzej Siewior
2013-08-19 6:06 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520E68A9.1020406@infradead.org \
--to=rdunlap-wegcikhe2lqwvfeawa7xhq@public$(echo .)gmane.org \
--cc=balbi-l0cyMroinI0@public$(echo .)gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rogerq-l0cyMroinI0@public$(echo .)gmane.org \
--cc=sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public$(echo .)gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox