From: Phillip Lougher <phillip@lougher•demon.co.uk>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Phillip Lougher <phillip@lougher•demon.co.uk>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: linux-next: build failure after merge of the squashfs tree
Date: Fri, 01 Nov 2013 04:09:05 +0000 [thread overview]
Message-ID: <52732961.4030501@lougher.demon.co.uk> (raw)
In-Reply-To: <52731AA2.1060800@lougher.demon.co.uk>
On 01/11/13 03:06, Phillip Lougher wrote:
> On 01/11/13 00:57, Stephen Rothwell wrote:
>> Hi Phillip,
>>
>> After merging the squashfs tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> fs/squashfs/decompressor_single.c: In function 'squashfs_decompressor_create':
>> fs/squashfs/decompressor_single.c:40:2: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
>> free(comp_opts);
>> ^
>
> Yup, applied and pushed the wrong patch.
>
> I noticed shortly afterwards, and pushed the correct patch, but you
> obviously had already done your pull.
>
> Squashfs: Refactor decompressor interface and code
> committer Phillip Lougher <phillip@squashfs•org.uk> 2013-10-31 23:06:37 (GMT)
>
> These things happen when you rush to get the patches ready for the linux-next
> tree.
>
> Squashfs is spare-time work for me, which means I often have no choice to
> work on it during the night. Previously when pushing such work for the
> linux-next tree I notice it never gets picked up until the next day, because
> a push at 4 AM is simply too late to get it into the linux-next tree for that
> day because you're in Australia.
>
> So I work out you pull around 11 PM GMT my time, and rush to get the patches
> ready for then. Screw up and this time around the process is even more
> thankless and humiliating than normal.
>
> Why don't you holier than thou guys get off your pedestals sometime and
> see what it's like for the hobbyists who don't get paid to do the work.
>
> Yeah maybe I'm getting to the point where I considering stopping doing
> this, because it has become utterly thankless.
Apologies. I was annoyed at myself and let my frustration show.
Phillip
>
> Cheers
>
> Phillip
>
>
>> fs/squashfs/decompressor_single.c:40:2: warning: incompatible implicit declaration of built-in function 'free' [enabled by default]
>>
>> Caused by commit 99d59ddb8a06 ("Squashfs: Refactor decompressor interface
>> and code").
>>
>> I have used the squashfs tree from next-20131031 for today.
>>
>
prev parent reply other threads:[~2013-11-01 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 0:57 linux-next: build failure after merge of the squashfs tree Stephen Rothwell
2013-11-01 3:06 ` Phillip Lougher
2013-11-01 4:09 ` Phillip Lougher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52732961.4030501@lougher.demon.co.uk \
--to=phillip@lougher$(echo .)demon.co.uk \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox