From: Guenter Roeck <linux@roeck-us•net>
To: Randy Dunlap <rdunlap@infradead•org>,
Stephen Rothwell <sfr@canb•auug.org.au>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Anish Bhatt <anish@chelsio•com>,
"David S. Miller" <davem@davemloft•net>,
"James E.J. Bottomley" <JBottomley@parallels•com>
Subject: Re: linux-next: Tree for Sep 19
Date: Fri, 19 Sep 2014 17:15:29 -0700 [thread overview]
Message-ID: <541CC721.2010207@roeck-us.net> (raw)
In-Reply-To: <541CAC81.9040404@infradead.org>
On 09/19/2014 03:21 PM, Randy Dunlap wrote:
> On 09/19/14 14:14, Guenter Roeck wrote:
>> On Fri, Sep 19, 2014 at 04:58:17PM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20140917:
>>>
>>> The fsl tree still had its build failure so I used the version from
>>> next-20140917.
>>>
>>> The v4l-dvb tree lost its build failure.
>>>
>>> The security tree gained a conflict against the file-locks tree.
>>>
>>> Non-merge commits (relative to Linus' tree): 6014
>>> 5488 files changed, 217522 insertions(+), 129375 deletions(-)
>>>
>>> ----------------------------------------------------------------------------
>>>
>> Guess this is most difficult one.
>>
>> mips:nlm_xlp_defconfig:
>>
>> warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has
>> unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)
>> warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has
>> unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)
>
> Yes, I have a patch sitting on my hard drive that makes LIBFCOE and TCM_QLA2XXX
> and SCSI_BNX2X_FCOE depend on SCSI_FC_ATTRS, but I'm not entirely happy about
> having to hunt these down (even with the help of kconfig warnings).
>
One key problem is that nlm_xlp_defconfig does not configure NET anymore.
this is after 'scsi_netlink : Make SCSI_NETLINK dependent on NET instead
of selecting NET' was applied.
In fact, there are many more affected configurations; the change from
"select XXX" to "depends XXX" has far reaching consequences, as many
configurations are no longer valid. For mips alone I find that this commit
changes the following configurations.
e55_defconfig
gpr_defconfig
ip27_defconfig
jazz_defconfig
loongson3_defconfig
malta_defconfig
malta_kvm_defconfig
malta_kvm_guest_defconfig
mtx1_defconfig
nlm_xlp_defconfig
nlm_xlr_defconfig
rm200_defconfig
e55_defconfig is almost the same as before, but only because CONFIG_NET
was not configured for it to start with. For all others, CONFIG_NET is
no longer set. This effectively means that out of 55 mips configurations,
11 or 20% are now bad. This is 3.17-rc5. vs. next-20140919.
Frankly, I don't think this change was really helpful. On the contrary,
we will be in a lot of trouble when this change makes it upstream.
It might be be a good idea to be much more careful when making such
changes. Cleaning up configuration dependencies is a laudable goal,
but when it breaks configurations all over the place it does more damage
than it is worth.
Guenter
next prev parent reply other threads:[~2014-09-20 0:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 6:58 linux-next: Tree for Sep 19 Stephen Rothwell
2014-09-19 19:04 ` Guenter Roeck
2014-09-19 19:15 ` Guenter Roeck
2014-09-20 19:36 ` Helge Deller
2014-09-20 21:01 ` Guenter Roeck
2014-09-21 19:43 ` Helge Deller
2014-09-19 19:42 ` Guenter Roeck
2014-09-19 20:06 ` Guenter Roeck
2014-09-22 14:40 ` Christoph Hellwig
2014-09-19 20:24 ` Guenter Roeck
2014-09-22 14:35 ` Christoph Hellwig
2014-09-19 21:14 ` Guenter Roeck
2014-09-19 21:42 ` Anish Bhatt
2014-09-20 0:18 ` Guenter Roeck
2014-09-19 22:21 ` Randy Dunlap
2014-09-19 22:28 ` Anish Bhatt
2014-09-19 22:35 ` Randy Dunlap
2014-09-20 0:15 ` Guenter Roeck [this message]
2014-09-20 1:09 ` Randy Dunlap
2014-09-20 1:43 ` Anish Bhatt
2014-09-20 2:08 ` David Miller
2014-09-20 2:40 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2025-09-19 15:05 Mark Brown
2024-09-19 5:46 Stephen Rothwell
2023-09-19 6:37 Stephen Rothwell
2022-09-19 9:47 Stephen Rothwell
2019-09-19 16:06 Mark Brown
2018-09-19 6:16 Stephen Rothwell
2017-09-19 4:15 Stephen Rothwell
2016-09-19 7:02 Stephen Rothwell
2013-09-19 3:59 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541CC721.2010207@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=JBottomley@parallels$(echo .)com \
--cc=anish@chelsio$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rdunlap@infradead$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox