Subject: Re: [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE

From: Andreas Ruprecht <[email-masked]>
Date: Fri, 21 Nov 2014 19:15:06 +0100

On 21.11.2014 19:13, Mauro Carvalho Chehab wrote:
> Em Fri, 21 Nov 2014 18:51:59 +0100
> Andreas Ruprecht <[email-masked]> escreveu:
> 
>> In smipcie.c, the function i2c_bit_add_bus() is called. This
>> function is defined by the I2C bit-banging interfaces enabled
>> with CONFIG_I2C_ALGOBIT.
>>
>> As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
>> be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
>> in a build error due to an undefined reference. This patch adds
>> the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
>>
>> Signed-off-by: Andreas Ruprecht <[email-masked]>
>> Reported-by: Jim Davis <[email-masked]>
>> ---
>>  drivers/media/pci/smipcie/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
>> index 75a2992..c728721 100644
>> --- a/drivers/media/pci/smipcie/Kconfig
>> +++ b/drivers/media/pci/smipcie/Kconfig
>> @@ -1,6 +1,6 @@
>>  config DVB_SMIPCIE
>>  	tristate "SMI PCIe DVBSky cards"
>> -	depends on DVB_CORE && PCI && I2C
>> +	depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT
> 
> IMHO, the best would be, instead, to select I2C_ALGOBIT.

Okay, I'll change that and submit a new version of this patch.

Regards,

Andreas Ruprecht