Subject: Re: [PATCH] regulators: Add missing dummy definition for regulator_list_voltage

From: "Suzuki K. Poulose" <[email-masked]>
Date: Fri, 10 Jul 2015 16:14:25 +0100

On 07/07/15 13:38, Mark Brown wrote:
> On Fri, Jun 26, 2015 at 12:06:50PM +0100, Suzuki K. Poulose wrote:
>
>> +static inline int regulator_list_voltage(struct regulator *regulator, unsigned selector)
>> +{
>> +	return 0;
>> +}
>
> I'd expect this stub to return -EINVAL since the voltage count should be
> zero for !REGULATOR (since we obviously can't count the number of
> voltages).
>
You are right, -EINVAL suites better. There are some users of the
API who consider 0 as invalid, but -EINVAL sounds better and covers
all the existing uses. Will resend the patch.

Thanks
Suzuki