From: Guenter Roeck <linux@roeck-us•net>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic•com>, rth@twiddle•net
Cc: ink@jurassic•park.msu.ru, mattst88@gmail•com,
will.deacon@arm•com, linux-alpha@vger•kernel.org,
linux-kernel@vger•kernel.org, paul.gortmaker@windriver•com,
mingo@kernel•org, linux-next@vger•kernel.org,
"Luis R. Rodriguez" <mcgrof@suse•com>
Subject: Re: [RFC] alpha: use asm-generic/io.h
Date: Fri, 31 Jul 2015 18:00:15 -0700 [thread overview]
Message-ID: <55BC1A1F.4090702@roeck-us.net> (raw)
In-Reply-To: <1438389509-16908-1-git-send-email-mcgrof@do-not-panic.com>
On 07/31/2015 05:38 PM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse•com>
>
> Since alpha does not include asm-generic/io.h it would mean
> alpha folks have to always carefully monitor asm-generic patches
> and before they get merged make sure their own arch implementation
> solution gets added. By using asm-generic/io.h alpha gets sensible
> defaults, in this case ioremap_uc() would be one example, where
> by default it would return NULL, so not implemented. When alpha
> folks get a chance then they can add the appropriate
> implementation.
>
> Reported-by: Guenter Roeck <linux@roeck-us•net>
> Cc: Paul Gortmaker <paul.gortmaker@windriver•com>
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse•com>
Doesn't work. Gives me lots of duplicate symbols.
Guenter
> ---
>
> The easy solution *for now* is to just do:
>
> #define ioremap_uc ioremap_nocache
>
> *But* that would have to be done for any other asm-generic/io.h collateral
> evolution, this on the other hand, would get it right for alpha from the
> get-go -- so I ask -- can this please be tested and if it is OK then consider
> it be merged?
>
> If we can't add asm-generic/io.h then the above define replacement would
> be the way to go.
>
> arch/alpha/include/asm/io.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
> index f05bdb4b1cb9..16a5bda42750 100644
> --- a/arch/alpha/include/asm/io.h
> +++ b/arch/alpha/include/asm/io.h
> @@ -581,4 +581,6 @@ extern void outsl (unsigned long port, const void *src, unsigned long count);
>
> #endif /* __KERNEL__ */
>
> +#include <asm-generic/io.h>
> +
> #endif /* __ALPHA_IO_H */
>
prev parent reply other threads:[~2015-08-01 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 0:38 [RFC] alpha: use asm-generic/io.h Luis R. Rodriguez
2015-08-01 1:00 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BC1A1F.4090702@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mcgrof@do-not-panic$(echo .)com \
--cc=mcgrof@suse$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=rth@twiddle$(echo .)net \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox