Subject: Re: randconfig build error with next-20150812, in drivers/extcon/extcon-palmas.c

From: Roger Quadros <[email-masked]>
Date: Thu, 13 Aug 2015 10:09:27 +0300

Hi,

On 12/08/15 17:46, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> warning: (INTEL_SOC_DTS_IOSF_CORE && PUNIT_ATOM_DEBUG) selects
> IOSF_MBI which has unmet direct dependencies (PCI)
> 
> drivers/extcon/extcon-palmas.c: In function ‘palmas_gpio_id_detect’:
> drivers/extcon/extcon-palmas.c:136:2: error: implicit declaration of
> function ‘gpiod_get_value_cansleep’
> [-Werror=implicit-function-declaration]
>   id = gpiod_get_value_cansleep(palmas_usb->id_gpiod);
>   ^
> drivers/extcon/extcon-palmas.c: In function ‘palmas_usb_probe’:
> drivers/extcon/extcon-palmas.c:211:2: error: implicit declaration of
> function ‘devm_gpiod_get_optional’
> [-Werror=implicit-function-declaration]
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
>   ^
> drivers/extcon/extcon-palmas.c:211:67: error: ‘GPIOD_ASIS’ undeclared
> (first use in this function)
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
>                                                                    ^
> drivers/extcon/extcon-palmas.c:211:67: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/extcon/extcon-palmas.c:228:3: error: implicit declaration of
> function ‘gpiod_set_debounce’ [-Werror=implicit-function-declaration]
>    status = gpiod_set_debounce(palmas_usb->id_gpiod,
>    ^
> drivers/extcon/extcon-palmas.c:275:3: error: implicit declaration of
> function ‘gpiod_to_irq’ [-Werror=implicit-function-declaration]
>    palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);
>    ^
> 
> 

Thanks for the catch.

This is because extcon-palmas.c doesn't include the header
include/linux/gpio/consumer.h

It will be addressed in the following thread
http://thread.gmane.org/gmane.linux.kernel/2019235

cheers,
-roger